Bug 29936 - [chromium] Update platform-specific #ifdefs in GraphicsContext3D.h
Summary: [chromium] Update platform-specific #ifdefs in GraphicsContext3D.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-30 14:52 PDT by Kenneth Russell
Modified: 2009-12-15 14:42 PST (History)
4 users (show)

See Also:

Attachments
Patch updating Chromium ifdefs (1.70 KB, patch)
2009-09-30 15:00 PDT, Kenneth Russell 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2009-09-30 14:52:30 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=29664 certain Chromium-specific #ifdefs were put under PLATFORM(SKIA). These should have been PLATFORM(CHROMIUM). Patch attached.

Note that this abstraction mechanism for factoring out the internals of the GraphicsContext3D could be used on all platforms.
Comment 1 Kenneth Russell 2009-09-30 15:00:53 PDT 
Created attachment 40402 [details]
Patch updating Chromium ifdefs
Comment 2 Darin Fisher (:fishd, Google) 2009-09-30 21:49:24 PDT 
Comment on attachment 40402 [details]
Patch updating Chromium ifdefs

> Index: WebCore/ChangeLog
...
> +2009-09-30  Kenneth Russell  <kbr@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [chromium] Update platform-specific #ifdefs in GraphicsContext3D.h
> +	https://bugs.webkit.org/show_bug.cgi?id=29936

oops... the tab stop there will prevent this from being committed by the commit-queue.
i'll commit this manually, but please watch out for tabs in the future.

r=me
Comment 3 Darin Fisher (:fishd, Google) 2009-10-05 16:58:21 PDT 
Landed as http://trac.webkit.org/changeset/49132