Bug 29917 – Enable Web Sockets in chromium build

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Fumitoshi Ukai]

Enable Web Sockets in chromium build.

[Fumitoshi Ukai]

Created attachment 40358 [details]
enable web sockets in chromium build

[Fumitoshi Ukai]

(In reply to comment #1)
> Created an attachment (id=40358) [details]
> enable web sockets in chromium build

This patch requires http://codereview.chromium.org/256010

[Fumitoshi Ukai]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=40358) [details] [details]
> > enable web sockets in chromium build
> 
> This patch requires http://codereview.chromium.org/256010

The patch of chromium side has been landed as http://src.chromium.org/viewvc/chrome?view=rev&revision=27835.

Could you review it, please?
Thanks.

[Eric Seidel (no email)]

Comment on attachment 40358 [details]
enable web sockets in chromium build

LGTM.

I'm not sure build "fixes" like this need review.

[Fumitoshi Ukai]

(In reply to comment #4)
> (From update of attachment 40358 [details])
> LGTM.
> 
> I'm not sure build "fixes" like this need review.

Thanks for review.

Landed as r49080.

[Alexey Proskuryakov]

I do not think that this should have been done before testing infrastructure was in place. Having untested code for large features in svn repository while it's being developed is one thing, but shipping it (even in nightly builds) is crossing the line, in my opinion.

That said, I do realize that the testing infrastructure is being actively worked on, and it took a great deal of effort already.