WebKit Bugzilla
You need to log in before you can comment on or make changes to this bug.
Enable Web Sockets in chromium build.
Created an attachment (id=40358) [details] enable web sockets in chromium build
(In reply to comment #1) > Created an attachment (id=40358) [details] [details] > enable web sockets in chromium build This patch requires http://codereview.chromium.org/256010
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=40358) [details] [details] [details] > > enable web sockets in chromium build > > This patch requires http://codereview.chromium.org/256010 The patch of chromium side has been landed as http://src.chromium.org/viewvc/chrome?view=rev&revision=27835. Could you review it, please? Thanks.
(From update of attachment 40358 [details]) LGTM. I'm not sure build "fixes" like this need review.
(In reply to comment #4) > (From update of attachment 40358 [details] [details]) > LGTM. > > I'm not sure build "fixes" like this need review. Thanks for review. Landed as r49080.
I do not think that this should have been done before testing infrastructure was in place. Having untested code for large features in svn repository while it's being developed is one thing, but shipping it (even in nightly builds) is crossing the line, in my opinion. That said, I do realize that the testing infrastructure is being actively worked on, and it took a great deal of effort already.