Bug 29917 - Enable Web Sockets in chromium build
Summary: Enable Web Sockets in chromium build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-30 04:01 PDT by Fumitoshi Ukai
Modified: 2009-10-06 14:52 PDT (History)
1 user (show)

See Also:

Attachments
enable web sockets in chromium build (1.87 KB, patch)
2009-09-30 04:22 PDT, Fumitoshi Ukai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-09-30 04:01:31 PDT 
Enable Web Sockets in chromium build.
Comment 1 Fumitoshi Ukai 2009-09-30 04:22:02 PDT 
Created attachment 40358 [details]
enable web sockets in chromium build
Comment 2 Fumitoshi Ukai 2009-09-30 04:22:53 PDT 
(In reply to comment #1)
> Created an attachment (id=40358) [details]
> enable web sockets in chromium build

This patch requires http://codereview.chromium.org/256010
Comment 3 Fumitoshi Ukai 2009-10-02 03:10:47 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=40358) [details] [details]
> > enable web sockets in chromium build
> 
> This patch requires http://codereview.chromium.org/256010

The patch of chromium side has been landed as http://src.chromium.org/viewvc/chrome?view=rev&revision=27835.

Could you review it, please?
Thanks.
Comment 4 Eric Seidel 2009-10-02 12:44:05 PDT 
Comment on attachment 40358 [details]
enable web sockets in chromium build

LGTM.

I'm not sure build "fixes" like this need review.
Comment 5 Fumitoshi Ukai 2009-10-04 19:53:43 PDT 
(In reply to comment #4)
> (From update of attachment 40358 [details])
> LGTM.
> 
> I'm not sure build "fixes" like this need review.

Thanks for review.

Landed as r49080.
Comment 6 Alexey Proskuryakov 2009-10-06 14:52:37 PDT 
I do not think that this should have been done before testing infrastructure was in place. Having untested code for large features in svn repository while it's being developed is one thing, but shipping it (even in nightly builds) is crossing the line, in my opinion.

That said, I do realize that the testing infrastructure is being actively worked on, and it took a great deal of effort already.