Bug 29917 - Enable Web Sockets in chromium build
: Enable Web Sockets in chromium build
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-09-30 04:01 PST by
Modified: 2009-10-06 14:52 PST (History)


Attachments
enable web sockets in chromium build (1.87 KB, patch)
2009-09-30 04:22 PST, Fumitoshi Ukai
eric: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-30 04:01:31 PST
Enable Web Sockets in chromium build.
------- Comment #1 From 2009-09-30 04:22:02 PST -------
Created an attachment (id=40358) [details]
enable web sockets in chromium build
------- Comment #2 From 2009-09-30 04:22:53 PST -------
(In reply to comment #1)
> Created an attachment (id=40358) [details] [details]
> enable web sockets in chromium build

This patch requires http://codereview.chromium.org/256010
------- Comment #3 From 2009-10-02 03:10:47 PST -------
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=40358) [details] [details] [details]
> > enable web sockets in chromium build
> 
> This patch requires http://codereview.chromium.org/256010

The patch of chromium side has been landed as http://src.chromium.org/viewvc/chrome?view=rev&revision=27835.

Could you review it, please?
Thanks.
------- Comment #4 From 2009-10-02 12:44:05 PST -------
(From update of attachment 40358 [details])
LGTM.

I'm not sure build "fixes" like this need review.
------- Comment #5 From 2009-10-04 19:53:43 PST -------
(In reply to comment #4)
> (From update of attachment 40358 [details] [details])
> LGTM.
> 
> I'm not sure build "fixes" like this need review.

Thanks for review.

Landed as r49080.
------- Comment #6 From 2009-10-06 14:52:37 PST -------
I do not think that this should have been done before testing infrastructure was in place. Having untested code for large features in svn repository while it's being developed is one thing, but shipping it (even in nightly builds) is crossing the line, in my opinion.

That said, I do realize that the testing infrastructure is being actively worked on, and it took a great deal of effort already.