http://trac.webkit.org/changeset/48895 brakes build if using JSVALUE32. - In emit_op_add and emitSlow_op_add missing the declaration of types variable. - In emit_op_add there are two typo (and some unnecessary code).
Created attachment 40352 [details] proposed patch eg. ARM and Qt port on Windows use JSVALUE32 now. Patch tested on ARM.
Created attachment 40359 [details] proposed patch patch updated: "unnecessary" replaced with "unreachable" in ChangeLog In additional tested with QtWebKit-win.
Comment on attachment 40359 [details] proposed patch r=me
Comment on attachment 40359 [details] proposed patch Rejecting patch 40359 from review queue. ggaren@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Committed revision 48938.
Geoff needs to be added to: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py as a reviewer. I'll take care of it.
I've added Geoff to the list of reviewers. bugzilla-tool (and thus the commit-queue) will recognize him as a valid reviewer now: http://trac.webkit.org/changeset/48949 If I've missed any other reviewers or committers they should feel encouraged to add themselves to that file w/o review.