Bug 29915 - Buildfix for platforms using JSVALUE32
Summary: Buildfix for platforms using JSVALUE32
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-09-30 02:33 PDT by Csaba Osztrogonác
Modified: 2009-09-30 15:08 PDT (History)
3 users (show)

See Also:

proposed patch (2.92 KB, patch)
2009-09-30 02:38 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed patch (2.97 KB, patch)
2009-09-30 04:22 PDT, Csaba Osztrogonác
ggaren: review+
ggaren: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2009-09-30 02:33:27 PDT
http://trac.webkit.org/changeset/48895 brakes build if using JSVALUE32.

- In emit_op_add and emitSlow_op_add missing the declaration of types variable.
- In emit_op_add there are two typo (and some unnecessary code).
Comment 1 Csaba Osztrogonác 2009-09-30 02:38:49 PDT
Created attachment 40352 [details]
proposed patch

eg. ARM and Qt port on Windows use JSVALUE32 now. Patch tested on ARM.
Comment 2 Csaba Osztrogonác 2009-09-30 04:22:07 PDT
Created attachment 40359 [details]
proposed patch

patch updated: "unnecessary" replaced with "unreachable" in ChangeLog

In additional tested with QtWebKit-win.
Comment 3 Geoffrey Garen 2009-09-30 11:21:12 PDT
Comment on attachment 40359 [details]
proposed patch

Comment 4 WebKit Commit Bot 2009-09-30 11:23:58 PDT
Comment on attachment 40359 [details]
proposed patch

Rejecting patch 40359 from review queue.

ggaren@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 5 Geoffrey Garen 2009-09-30 11:27:10 PDT
Committed revision 48938.
Comment 6 Eric Seidel (no email) 2009-09-30 15:00:58 PDT
Geoff needs to be added to:
as a reviewer.  I'll take care of it.
Comment 7 Eric Seidel (no email) 2009-09-30 15:08:58 PDT
I've added Geoff to the list of reviewers.  bugzilla-tool (and thus the commit-queue) will recognize him as a valid reviewer now:

If I've missed any other reviewers or committers they should feel encouraged to add themselves to that file w/o review.