[Chromium] Incorrect conditions in WebCore.gyp

[Chris Hawk]

/trunk/WebCore/WebCore.gyp/WebCore.gyp has a single target ('webcore') with two 'conditions' values. The first one is ignored leaving out some needed definitions (namely, WEBCORE_NAVIGATOR_PLATFORM for Mac, Windows, and Linux).

The problem stems from a merge at http://codereview.chromium.org/208029

[Chris Hawk]

Created attachment 40336 [details]
Patch the collapses the two condition sections into one

[Eric Seidel (no email)]

Comment on attachment 40336 [details]
Patch the collapses the two condition sections into one

Forgot to click the "patch" checkbox.  Tools like "bugzilla-tool post-diff" will do all that for you.

Also your ChangeLog should really have the bug number in it.  prepare-ChangeLog --bug will do that.

This is covered in http://webkit.org/coding/contributing.html

[Dimitri Glazkov (Google)]

Comment on attachment 40336 [details]
Patch the collapses the two condition sections into one

This looks great, except:

> +        Fix for conditionals in the WebCore gyp file, which contained two separate
> +        'conditions' values for the webcore target. The first entry was ignored,
> +        resulting in some missine defines.

Need bug URL.

[Chris Hawk]

Created attachment 40385 [details]
Previous patch + bug URL

[Dimitri Glazkov (Google)]

Comment on attachment 40385 [details]
Previous patch + bug URL

r=me.

[WebKit Commit Bot]

Comment on attachment 40385 [details]
Previous patch + bug URL

Clearing flags on attachment: 40385

Committed r48940: <http://trac.webkit.org/changeset/48940>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.