RESOLVED FIXED 29898
update-webkit --chromium fails to set .gclient file 
https://bugs.webkit.org/show_bug.cgi?id=29898
Summary update-webkit --chromium fails to set .gclient file
Yaar Schnitman
Reported 2009-09-29 14:58:46 PDT
The error codes of exec calls in the update-webkit-chromium perl scripts are not captured correctly.
Attachments
minor error handling changes (2.13 KB, patch)
2009-09-29 15:01 PDT, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yaar Schnitman
Comment 1 2009-09-29 15:01:44 PDT
Created attachment 40327 [details] minor error handling changes exec(...) doesn't return the error codes we expect. reverted to using system(...)
David Kilzer (:ddkilzer)
Comment 2 2009-09-29 18:01:59 PDT
Comment on attachment 40327 [details] minor error handling changes > diff --git a/WebKitTools/Scripts/update-webkit b/WebKitTools/Scripts/update-webkit > } elsif (isChromium()) { > - system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die; > + system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die $!; > } elsif (isAppleWinWebKit()) { > system("perl", "WebKitTools/Scripts/update-webkit-auxiliary-libs") == 0 or die; > } Someday we may be able to use something other than "perl" here. See Bug 29656 Comment #8. r=me
WebKit Commit Bot
Comment 3 2009-09-29 18:46:37 PDT
Comment on attachment 40327 [details] minor error handling changes Clearing flags on attachment: 40327 Committed r48916: <http://trac.webkit.org/changeset/48916>
WebKit Commit Bot
Comment 4 2009-09-29 18:46:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.