Bug 29897 - REGRESSION(r47820-r47822): Profiles aren't added to the inspector unless the inspector is already open when the profile completes
Summary: REGRESSION(r47820-r47822): Profiles aren't added to the inspector unless the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-29 14:26 PDT by Oliver Hunt
Modified: 2009-09-29 15:10 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.63 KB, patch)
2009-09-29 14:51 PDT, Pavel Feldman 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-09-29 14:26:49 PDT 
When using the entry in the develop menu to start a profile, the profile is not inserted into the profile view unless the inspector has already been opened.

To reproduce:
1. Go to a site with js
2. Develop | Start profiling JavaScript
3. wait a bit
4. Develop | Stop profiling JavaScript

Result:
The inspector opens to the profiler pane, but doesn't display the profile
Comment 1 Pavel Feldman 2009-09-29 14:51:45 PDT 
Created attachment 40326 [details]
patch

Regression introduced in r47821. Thanks for the report.
Comment 2 Oliver Hunt 2009-09-29 14:55:15 PDT 
Comment on attachment 40326 [details]
patch

how does this interact with alloc profiles?  eg. if the first profile was an alloc profile would it display?
Comment 3 Pavel Feldman 2009-09-29 14:59:42 PDT 
(In reply to comment #2)
> (From update of attachment 40326 [details])
> how does this interact with alloc profiles?  eg. if the first profile was an
> alloc profile would it display?

This obviously needs to be resolved when we add different profile flavors (heap profiles are behind the flag now). Adding a FIXME note there and landing.
Comment 4 Pavel Feldman 2009-09-29 15:10:22 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ProfilesPanel.js
Committed r48907