RESOLVED FIXED 29897
REGRESSION(r47820-r47822): Profiles aren't added to the inspector unless the inspector is already open when the profile completes 
https://bugs.webkit.org/show_bug.cgi?id=29897
Summary REGRESSION(r47820-r47822): Profiles aren't added to the inspector unless the ...
Oliver Hunt
Reported 2009-09-29 14:26:49 PDT
When using the entry in the develop menu to start a profile, the profile is not inserted into the profile view unless the inspector has already been opened. To reproduce: 1. Go to a site with js 2. Develop | Start profiling JavaScript 3. wait a bit 4. Develop | Stop profiling JavaScript Result: The inspector opens to the profiler pane, but doesn't display the profile
Attachments
patch (1.63 KB, patch)
2009-09-29 14:51 PDT, Pavel Feldman 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-09-29 14:51:45 PDT
Created attachment 40326 [details] patch Regression introduced in r47821. Thanks for the report.
Oliver Hunt
Comment 2 2009-09-29 14:55:15 PDT
Comment on attachment 40326 [details] patch how does this interact with alloc profiles? eg. if the first profile was an alloc profile would it display?
Pavel Feldman
Comment 3 2009-09-29 14:59:42 PDT
(In reply to comment #2) > (From update of attachment 40326 [details]) > how does this interact with alloc profiles? eg. if the first profile was an > alloc profile would it display? This obviously needs to be resolved when we add different profile flavors (heap profiles are behind the flag now). Adding a FIXME note there and landing.
Pavel Feldman
Comment 4 2009-09-29 15:10:22 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ProfilesPanel.js Committed r48907
Note You need to log in before you can comment on or make changes to this bug.