Bug 29893 - [Gtk][Layout tests] Generate results for dom tests
Summary: [Gtk][Layout tests] Generate results for dom tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-29 13:28 PDT by Zan Dobersek
Modified: 2009-10-15 14:02 PDT (History)
2 users (show)

See Also:


Attachments
Comparisment of Gtk and Mac render trees (16.13 KB, text/plain)
2009-09-29 13:28 PDT, Zan Dobersek
no flags Details
Generated results (15.67 KB, patch)
2009-09-30 09:58 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Generated results (12.21 KB, patch)
2009-10-11 10:53 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2009-09-29 13:28:49 PDT
Created attachment 40320 [details]
Comparisment of Gtk and Mac render trees

Currently, 15 tests in dom/ directory need to have results generated:
dom/xhtml/level3/core/canonicalform08.xhtml
dom/xhtml/level3/core/canonicalform09.xhtml
dom/xhtml/level3/core/documentgetinputencoding03.xhtml
dom/xhtml/level3/core/entitygetinputencoding02.xhtml
dom/xhtml/level3/core/entitygetxmlversion02.xhtml
dom/xhtml/level3/core/nodegetbaseuri05.xhtml
dom/xhtml/level3/core/nodegetbaseuri07.xhtml
dom/xhtml/level3/core/nodegetbaseuri09.xhtml
dom/xhtml/level3/core/nodegetbaseuri10.xhtml
dom/xhtml/level3/core/nodegetbaseuri11.xhtml
dom/xhtml/level3/core/nodegetbaseuri15.xhtml
dom/xhtml/level3/core/nodegetbaseuri17.xhtml
dom/xhtml/level3/core/nodegetbaseuri18.xhtml
dom/xhtml/level3/core/nodelookupnamespaceuri01.xhtml
dom/xhtml/level3/core/nodelookupprefix19.xhtml

Attached is the comparisment of Mac and Gtk render trees.

Analysis: Differences, if any, appear beacuse of the different font metrics.
Comment 1 Zan Dobersek 2009-09-30 09:58:48 PDT
Created attachment 40377 [details]
Generated results

Adds generated results and enables now passing tests in the Skipped.
Comment 2 Holger Freyther 2009-10-10 05:49:07 PDT
The NP_Initialize messages are coming from the totem plugin? If that is the case it is not too good to put that into our expected result. I think the Qt folks added a way to filter out such messages.
Comment 3 Zan Dobersek 2009-10-11 10:53:32 PDT
Created attachment 41002 [details]
Generated results

The previous patch was malformed, it was adding many files that weren't actually wanted, or required.

This one now adds only generated results for tests that we are removing from the Skipped.
Comment 4 Eric Seidel (no email) 2009-10-15 13:38:22 PDT
Comment on attachment 41002 [details]
Generated results

LGTM.
Comment 5 WebKit Commit Bot 2009-10-15 14:02:03 PDT
Comment on attachment 41002 [details]
Generated results

Clearing flags on attachment: 41002

Committed r49652: <http://trac.webkit.org/changeset/49652>
Comment 6 WebKit Commit Bot 2009-10-15 14:02:07 PDT
All reviewed patches have been landed.  Closing bug.