RESOLVED FIXED 29888
[V8] XMLHttpRequest attribute event listeners are always created as object listeners. 
https://bugs.webkit.org/show_bug.cgi?id=29888
Summary [V8] XMLHttpRequest attribute event listeners are always created as object li...
Dimitri Glazkov (Google)
Reported 2009-09-29 10:45:41 PDT
The recent event listener refactoring revealed a bug, where we never explicitly say if an event listener is attribute for XHR. This leads to attribute listeners always created as object listeners, and thus never being cleared when setting new attribute listener. Bad.
Attachments
Fix attribute event listeners in XHR, v1. (6.43 KB, patch)
2009-09-29 11:08 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Fix attribute event listeners in XHR, v2. (6.74 KB, patch)
2009-09-29 11:47 PDT, Dimitri Glazkov (Google) 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-09-29 11:08:49 PDT
Created attachment 40312 [details] Fix attribute event listeners in XHR, v1. WebCore/ChangeLog | 14 ++++++++++++ .../bindings/v8/custom/V8XMLHttpRequestCustom.cpp | 22 ++++++++++---------- 2 files changed, 25 insertions(+), 11 deletions(-)
Vitaly Repeshko
Comment 2 2009-09-29 11:18:28 PDT
(In reply to comment #1) > Created an attachment (id=40312) [details] > Fix attribute event listeners in XHR, v1. > > WebCore/ChangeLog | 14 ++++++++++++ > .../bindings/v8/custom/V8XMLHttpRequestCustom.cpp | 22 ++++++++++---------- > 2 files changed, 25 insertions(+), 11 deletions(-) LGTM.
Dimitri Glazkov (Google)
Comment 3 2009-09-29 11:47:10 PDT
Created attachment 40314 [details] Fix attribute event listeners in XHR, v2. WebCore/ChangeLog | 14 +++++++++++ .../bindings/v8/custom/V8XMLHttpRequestCustom.cpp | 25 +++++++++++-------- 2 files changed, 28 insertions(+), 11 deletions(-)
Dimitri Glazkov (Google)
Comment 4 2009-09-29 11:47:45 PDT
bools == ew. Used enums instead.
Vitaly Repeshko
Comment 5 2009-09-29 11:51:06 PDT
(In reply to comment #4) > bools == ew. Used enums instead. Enum names are misleading here since V8ObjectEventListener can be an attribute listener.
Dimitri Glazkov (Google)
Comment 6 2009-09-29 12:27:44 PDT
Landed as http://trac.webkit.org/changeset/48889.
Note You need to log in before you can comment on or make changes to this bug.