Bug 29887 - Qt WebKit is sending the policy changed error for any QNetworkReply error.
Summary: Qt WebKit is sending the policy changed error for any QNetworkReply error.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-09-29 10:19 PDT by Kenneth Rohde Christiansen
Modified: 2009-10-27 10:45 PDT (History)
2 users (show)

See Also:

Attachments
Fix handling of QNetworkReply errors (2.95 KB, patch)
2009-09-29 10:19 PDT, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2009-09-29 10:19:16 PDT 
Created attachment 40307 [details]
Fix handling of QNetworkReply errors

Patch to fix the handling of QNetworkReply errors.
Comment 1 Eric Seidel (no email) 2009-09-29 12:20:02 PDT 
Comment on attachment 40307 [details]
Fix handling of QNetworkReply errors

Why wouldn't this check be inside sendResponseIfNeeded()?

I really don't know this code at all, but the "ifNeeded" makes me feel like maybe that function should have this kind of check.  It's a little strange to conditionally call "ifNeeded" functions.
Comment 2 Kenneth Rohde Christiansen 2009-09-29 12:23:29 PDT 
(In reply to comment #1)
> (From update of attachment 40307 [details])
> Why wouldn't this check be inside sendResponseIfNeeded()?
> 
> I really don't know this code at all, but the "ifNeeded" makes me feel like
> maybe that function should have this kind of check.  It's a little strange to
> conditionally call "ifNeeded" functions.

Yes, I actually thought about that, but I wasn't sure. Let's see if Simon has some comments.
Comment 3 Kenneth Rohde Christiansen 2009-09-29 15:13:28 PDT 
Comment on attachment 40307 [details]
Fix handling of QNetworkReply errors

Landed in 48900.
Comment 4 Antonio Gomes 2009-10-27 10:37:07 PDT 
(In reply to comment #1)
> (From update of attachment 40307 [details])
> Why wouldn't this check be inside sendResponseIfNeeded()?
> 
> I really don't know this code at all, but the "ifNeeded" makes me feel like
> maybe that function should have this kind of check.  It's a little strange to
> conditionally call "ifNeeded" functions.

i agree this  "if" should move to inside that *ifneeded* function.
Comment 5 Kenneth Rohde Christiansen 2009-10-27 10:45:11 PDT 
That is already done.