RESOLVED FIXED298178
[WebXR][OpenXR] Add API to get consent required/optional features of WebKitXRPermissionRequest 
https://bugs.webkit.org/show_bug.cgi?id=298178
Summary [WebXR][OpenXR] Add API to get consent required/optional features of WebKitXR...
Fujii Hironori
Reported 2025-08-31 17:02:27 PDT
[WebXR][OpenXR] Add API to get concent required/optional features of WebKitXRPermissionRequest
Attachments
Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2025-08-31 18:01:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/49447
EWS
Comment 2 2025-09-04 17:00:56 PDT
Committed 299591@main (91c148a27b2e): <https://commits.webkit.org/299591@main> Reviewed commits have been landed. Closing PR #49447 and removing active labels.
Fujii Hironori
Comment 3 2025-09-07 08:22:01 PDT
Lots of warning after 299591@main with clang++. /home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:351:5: error: pasting formed '" ""viewer"', an invalid preprocessing token 351 | APPEND_FEATURE(WEBKIT_XR_SESSION_FEATURES_VIEWER, "viewer"); | ^ /home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:350:35: note: expanded from macro 'APPEND_FEATURE' 350 | g_string_append(str, (" " ## name) + !(count++)); | ^ /home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:352:5: error: pasting formed '" ""local"', an invalid preprocessing token 352 | APPEND_FEATURE(WEBKIT_XR_SESSION_FEATURES_LOCAL, "local"); | ^ /home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:350:35: note: expanded from macro 'APPEND_FEATURE' 350 | g_string_append(str, (" " ## name) + !(count++)); | ^ (...) /home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:349:40: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int] 349 | g_string_append(str, " viewer" + !(count++)); | ~~~~~~~~~~^~~~~~~~~~~~ /usr/include/glib-2.0/glib/gstring.h:269:26: note: expanded from macro 'g_string_append' 269 | (__builtin_constant_p (val) ? \ | ^~~ /home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:349:40: note: use array indexing to silence this warning 349 | g_string_append(str, " viewer" + !(count++)); | ^ | & [ /usr/include/glib-2.0/glib/gstring.h:269:26: note: expanded from macro 'g_string_append' 269 | (__builtin_constant_p (val) ? \ | ^ /home/fujii/webkit/wc/Tools/MiniBrowser/gtk/BrowserTab.c:349:40: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int] 349 | g_string_append(str, " viewer" + !(count++)); | ~~~~~~~~~~^~~~~~~~~~~~ /usr/include/glib-2.0/glib/gstring.h:271:35: note: expanded from macro 'g_string_append' 271 | const char * const __val = (val); \ (...)
Fujii Hironori
Comment 4 2025-09-07 08:26:11 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/50424
EWS
Comment 5 2025-09-07 08:34:32 PDT
Committed 299670@main (d65a76dbf3a5): <https://commits.webkit.org/299670@main> Reviewed commits have been landed. Closing PR #50424 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.