Bug 29811 - Text in Inspector's Styles gear menu is invisible
Summary: Text in Inspector's Styles gear menu is invisible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar, PlatformOnly
: 30192 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-09-28 09:24 PDT by Adam Roben (:aroben)
Modified: 2009-10-08 13:30 PDT (History)
3 users (show)

See Also:


Attachments
Fix described by comment 5 (1.15 KB, patch)
2009-10-08 10:21 PDT, Brian Weinstein
aroben: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-09-28 09:24:30 PDT
To reproduce:

1. Go to any page
2. Right-click and choose "Inspect Element"
3. Hover over the Styles section header in the right sidebar
4. Click on the gear that appears

The text in the menu is invisible.

It looks like this is due to <http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/inspector.css?rev=48809#L1617>, where we set the color of the <select> to be transparent. This affects the text in the menu on Windows.

One fix for this would be to add a rule like:

.pane > .title > select > option { color: black }

"black" might not always be the right color, though.
Comment 1 Adam Roben (:aroben) 2009-09-28 09:27:31 PDT
<rdar://problem/7257831>
Comment 2 Timothy Hatcher 2009-09-28 09:39:16 PDT
I think we could also use:

.pane > .title > select { text-indent: 30; }

And then let the color be unchanged.
Comment 3 Adam Roben (:aroben) 2009-09-29 15:03:13 PDT
(In reply to comment #2)
> I think we could also use:
> 
> .pane > .title > select { text-indent: 30; }
> 
> And then let the color be unchanged.

I'm pretty sure that doing that will indent the text inside the menu, too.
Comment 4 Brian Weinstein 2009-10-07 23:07:58 PDT
*** Bug 30192 has been marked as a duplicate of this bug. ***
Comment 5 Timothy Hatcher 2009-10-08 08:22:30 PDT
So the fix would be:

.pane > .title > select > option {
    color: black;
}

.pane > .title > select > hr {
    color: black;
}
Comment 6 Brian Weinstein 2009-10-08 10:21:15 PDT
Created attachment 40888 [details]
Fix described by comment 5
Comment 7 Adam Roben (:aroben) 2009-10-08 10:38:56 PDT
Comment on attachment 40888 [details]
Fix described by comment 5

r=me
Comment 8 Brian Weinstein 2009-10-08 13:30:38 PDT
Committed in http://trac.webkit.org/changeset/49310.