Bug 29808 – [Qt] assertions to be visible on Symbian

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Janne Koskinen]

Created attachment 40236 [details]
vprintf patch

Qt port of Symbian uses Open C to access posix libraries.
assertions.h uses vprintf to print out the assert messages into stderr.
In Open C stderr prints are lost somewhere and only stdout can be seen from
log files. This change that makes assert messages to be visible on Symbian.

[David Kilzer (:ddkilzer)]

Comment on attachment 40236 [details]
vprintf patch

> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index f6a644a..894ff9a 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,15 @@
> [phone]  Janne Koskinen  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] Assert messages prints visible in Symbian
> +
> +        Asserts use vprintf to print the messages to stderr.
> +        In Symbian Open C it is not possible to see stderr so
> +        I routed the messages to stdout instead.
> +
> +        * wtf/Assertions.cpp:
> +

Please include a reference to the bug URL in the ChangeLog entry.

> +#ifdef PLATFORM(SYMBIAN)

This should be:

#if PLATFORM(SYMBIAN)

r- to address the above issues.

[Janne Koskinen]

Created attachment 40286 [details]
vprintf patch second attempt

Corrected patch based on review comments.

[Janne Koskinen]

Created attachment 40287 [details]
vprintf patch third attempt

Corrected based on review comments.
Added bug url and changed to use #if instead of #ifdef.

[David Kilzer (:ddkilzer)]

Comment on attachment 40287 [details]
vprintf patch third attempt

r=me

[WebKit Commit Bot]

Comment on attachment 40287 [details]
vprintf patch third attempt

Clearing flags on attachment: 40287

Committed r48878: <http://trac.webkit.org/changeset/48878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.