If using cmd.exe shell on Windows, you should give correct parameters to mkdir command. The mkdir doesn't handle slashes in filepath, but backslashes. And if you pass -p parameter to mkdir, it will create directory named -p. You can create 1\2\3 directory structure without any additional switch on Windows.
Created attachment 40225 [details] proposed patch
Comment on attachment 40225 [details] proposed patch Overall, this is a nice clean-up! Comments below. > + my $mkdirParentsSwitch = (($^O eq "MSWin32") ? "" : "-p"); A couple things here: - Instead of making a custom $mkdirParentsSwitch variable, I'd rather see you add an @mkdirArgs variable, and only add the "-p" switch to it if necessary. my @mkdirArgs; push @mkdirArgs, "-p" if !isWindows(); - The ($^O eq "MSWin32") test should really be isWindows() instead. (If you don't want to test for Cygwin, then fix isWindows() to only test for Windows, and update run-webkit-test to use "isCygwin() || isWindows()" in the place where it uses isWindows() now.) The rest of the changes look good! r- to address the above issues.
Created attachment 40297 [details] proposed patch Thx for constructive suggestions, I followed them, and patch updated.
Created attachment 40298 [details] proposed patch
Comment on attachment 40298 [details] proposed patch Very nice! r=me
Comment on attachment 40298 [details] proposed patch Clearing flags on attachment: 40298 Committed r48880: <http://trac.webkit.org/changeset/48880>
All reviewed patches have been landed. Closing bug.