Created attachment 40194 [details] Comparisment of Gtk and Mac render trees Currently, 5 tests in transforms/ directory need to have results generated: transforms/no_transform_hit_testing.html transforms/2d/compound-transforms-vs-containers.html transforms/2d/transform-borderbox.html transforms/2d/transform-origin-borderbox.html transforms/2d/zoom-menulist.html Attached is the comparisment of Mac and Gtk render trees. Analysis: Beacuse of the differences in the metrics, RenderText objects are 2 pixels higher in the Gtk's generated results. Subsequently the parents are also higher, making their siblings being pushed down the y axis for an even number of pixels. Noticable difference appears between generated results for test transforms/2d/zoom-menulist.html: - RenderBlock (anonymous) at (0,58) size 784x66 ? ^^ ^^ + RenderBlock (anonymous) at (0,63) size 784x79 ? ^^ ^^ - RenderMenuList {SELECT} at (6,6) size 185x54 [bgcolor=#FFFFFF] [border: (3px solid #000000)] ? ^^ ^^ ------------------------------ + RenderMenuList {SELECT} at (6,6) size 136x67 [bgcolor=#FFFFFF] ? ^^ ^^ - RenderBlock (anonymous) at (3,3) size 179x48 ? ^ ^ ^ --- + RenderBlock (anonymous) at (4,4) size 111x59 ? ^ ^ ^^^^ - RenderText at (24,3) size 65x39 ? ^^ ^ ^ -- + RenderText at (0,0) size 80x59 ? ^ ^ ^^^ - text run at (24,3) width 65: "One" ? ^^ ^ ^^ + text run at (0,0) width 80: "One" ? ^ ^ ^^ I recon this has something to do with Mac port's rendering of menu lists, or perhaps the menu list isn't even zoomed at all on the Gtk side. A separate bug should be opened for this issue, adding generated results to this test only when the bug is resolved, whichever way it goes.
Created attachment 40199 [details] Generated results Adds generated results and enables now passing tests in the Skipped.
Comment on attachment 40199 [details] Generated results r=me
Comment on attachment 40199 [details] Generated results Clearing flags on attachment: 40199 Committed r48847: <http://trac.webkit.org/changeset/48847>
All reviewed patches have been landed. Closing bug.