WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29784
[Gtk][Layout tests] Generate results for css3 tests
https://bugs.webkit.org/show_bug.cgi?id=29784
Summary
[Gtk][Layout tests] Generate results for css3 tests
Zan Dobersek
Reported
2009-09-27 09:41:40 PDT
Created
attachment 40192
[details]
Comparisment of Gtk and Mac render trees Currently, 4 tests in animations/ directory need to have results generated: css3/css3-modsel-33.html css3/css3-modsel-35.html css3/css3-modsel-36.html css3/css3-modsel-37.html Attached is the comparisment of Mac and Gtk render trees. Analysis: In all four tests, RenderText objects are 2 pixels higher in the Gtk's generated results beacuse of different font metrics. Subsequently RenderText's parents have increased height and their sibling objects may be pushed down the y axis for any even number of pixels.
Attachments
Comparisment of Gtk and Mac render trees
(16.43 KB, text/plain)
2009-09-27 09:41 PDT
,
Zan Dobersek
no flags
Details
Generated results
(7.96 KB, patch)
2009-09-27 10:29 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Generated results
(7.95 KB, patch)
2009-09-27 10:42 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2009-09-27 10:29:05 PDT
Created
attachment 40198
[details]
Generated results Adds generated results and enables now passing tests in the Skipped.
Zan Dobersek
Comment 2
2009-09-27 10:42:15 PDT
Created
attachment 40201
[details]
Generated results Properly descirbes the change in ChangeLog.
David Kilzer (:ddkilzer)
Comment 3
2009-09-28 17:22:56 PDT
Comment on
attachment 40201
[details]
Generated results r=me
WebKit Commit Bot
Comment 4
2009-09-28 17:40:40 PDT
Comment on
attachment 40201
[details]
Generated results Rejecting patch 40201 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11339 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8970 tests run. 253.81s total testing time 8969 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 5
2009-09-28 17:58:32 PDT
Comment on
attachment 40201
[details]
Generated results Sigh. You were bitten by
bug 29322
again. :(
WebKit Commit Bot
Comment 6
2009-09-28 18:10:19 PDT
Comment on
attachment 40201
[details]
Generated results Clearing flags on attachment: 40201 Committed
r48851
: <
http://trac.webkit.org/changeset/48851
>
WebKit Commit Bot
Comment 7
2009-09-28 18:10:22 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug