Created attachment 40192 [details] Comparisment of Gtk and Mac render trees Currently, 4 tests in animations/ directory need to have results generated: css3/css3-modsel-33.html css3/css3-modsel-35.html css3/css3-modsel-36.html css3/css3-modsel-37.html Attached is the comparisment of Mac and Gtk render trees. Analysis: In all four tests, RenderText objects are 2 pixels higher in the Gtk's generated results beacuse of different font metrics. Subsequently RenderText's parents have increased height and their sibling objects may be pushed down the y axis for any even number of pixels.
Created attachment 40198 [details] Generated results Adds generated results and enables now passing tests in the Skipped.
Created attachment 40201 [details] Generated results Properly descirbes the change in ChangeLog.
Comment on attachment 40201 [details] Generated results r=me
Comment on attachment 40201 [details] Generated results Rejecting patch 40201 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11339 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8970 tests run. 253.81s total testing time 8969 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Comment on attachment 40201 [details] Generated results Sigh. You were bitten by bug 29322 again. :(
Comment on attachment 40201 [details] Generated results Clearing flags on attachment: 40201 Committed r48851: <http://trac.webkit.org/changeset/48851>
All reviewed patches have been landed. Closing bug.