Bug 29783 - [Gtk][Layout tests] Generate results for animations tests
Summary: [Gtk][Layout tests] Generate results for animations tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-27 09:32 PDT by Zan Dobersek
Modified: 2009-09-28 17:35 PDT (History)
2 users (show)

See Also:


Attachments
Comparisment of Gtk and Mac render trees (3.65 KB, text/plain)
2009-09-27 09:32 PDT, Zan Dobersek
no flags Details
Generated results (3.01 KB, patch)
2009-09-27 10:20 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2009-09-27 09:32:19 PDT
Created attachment 40191 [details]
Comparisment of Gtk and Mac render trees

Currently, 2 tests in animations/ directory need to have results generated:
animations/animation-drt-api-multiple-keyframes.html
animations/animation-drt-api.html

Attached is the comparisment of Mac and Gtk render trees.

Analysis: In both tests, a h1 heading is used. Because of different font metrcis RenderText objects for these headings are 5 pixels higher on the Gtk port. This should be ignored.
Comment 1 Zan Dobersek 2009-09-27 10:20:46 PDT
Created attachment 40197 [details]
Generated results

Adds generated results and enables now passing tests in the Skipped.
Comment 2 David Kilzer (:ddkilzer) 2009-09-28 17:21:59 PDT
Comment on attachment 40197 [details]
Generated results

r=me
Comment 3 WebKit Commit Bot 2009-09-28 17:35:10 PDT
Comment on attachment 40197 [details]
Generated results

Clearing flags on attachment: 40197

Committed r48849: <http://trac.webkit.org/changeset/48849>
Comment 4 WebKit Commit Bot 2009-09-28 17:35:14 PDT
All reviewed patches have been landed.  Closing bug.