I discovered that WebKit doesn't ensure that the dictionaries it is trying to use exist at all. In the worst case, this results in a crash when right-clicking a misspelled word.
Created attachment 40182 [details] Make sure dicts exist With this change enchant is asked for every dictionary whether it actually exists, otherwise it is not added to the list.
I've been experiencing a crash in liferea (https://sourceforge.net/tracker/?func=detail&atid=581684&aid=2865307&group_id=87005) which the developers think is related to this issue. I applied the patch and it still crashes. Either the patch is bad, or the issue is different. I'd appreciate your comments.
Comment on attachment 40182 [details] Make sure dicts exist r=me, I'm setting cq-, because I assume you are going to commit yourself =).
(In reply to comment #2) > I've been experiencing a crash in liferea > (https://sourceforge.net/tracker/?func=detail&atid=581684&aid=2865307&group_id=87005) > which the developers think is related to this issue. I applied the patch and > it still crashes. Either the patch is bad, or the issue is different. I'd > appreciate your comments. OK, so this has absolutely no relation to this problem. The dictionary the trace refers to is related to javascript properties mapping/caching, rather than to spelling. If that is webkit 1.1.15, I highly recommend upgrading to 1.1.15.1. If you can still reproduce that crash with 1.1.15.1, please file a bug report specifically for it.
(In reply to comment #3) > (From update of attachment 40182 [details]) > r=me, I'm setting cq-, because I assume you are going to commit yourself =). Landed as http://trac.webkit.org/changeset/49437. This patch also fixed a few critical warnings wrt enchant in some layout tests, which is why I landed it. I hope that's ok.