Bug 29771 - "Use of uninitialized value $result" warnings when ignoring metrics in run-webkit-tests.
Summary: "Use of uninitialized value $result" warnings when ignoring metrics in run-we...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-26 13:14 PDT by Jakub Wieczorek
Modified: 2009-09-27 12:45 PDT (History)
1 user (show)

See Also:

Attachments
Do not strip the metrics when there is no expected result for a test. (1.47 KB, patch)
2009-09-26 13:20 PDT, Jakub Wieczorek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Wieczorek 2009-09-26 13:14:45 PDT 
When a test is new, i.e. it doesn't have the expected result, running the test without metrics (--ignore-metrics) results in a bunch of following warnings:

Use of uninitialized value $result in substitution (s///) at (...)/WebKitTools/Scripts/run-webkit-tests line 1951, <IN> line 512.

There is no point in stripping metrics when there is no result for a test.
Comment 1 Jakub Wieczorek 2009-09-26 13:20:23 PDT 
Created attachment 40179 [details]
Do not strip the metrics when there is no expected result for a test.
Comment 2 WebKit Commit Bot 2009-09-27 12:45:32 PDT 
Comment on attachment 40179 [details]
Do not strip the metrics when there is no expected result for a test.

Clearing flags on attachment: 40179

Committed r48803: <http://trac.webkit.org/changeset/48803>
Comment 3 WebKit Commit Bot 2009-09-27 12:45:35 PDT 
All reviewed patches have been landed.  Closing bug.