Bug 29770 - Web Inspector: DOM store is being unbound twice, leading to assertion failure
Summary: Web Inspector: DOM store is being unbound twice, leading to assertion failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-26 11:35 PDT by Pavel Feldman
Modified: 2009-09-27 02:19 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.29 KB, patch)
2009-09-26 11:39 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-09-26 11:35:29 PDT 
1. Open Web Inspector
2. Type something in console (completions are being calculated for window, touching localStore, lazily creating it)
3. Close Web Inspector (unbind is called once)
4. Refresh the page (unbind is called again) -> ASSERTION fails

We keep stores bound only while inspector window is show, so this assersion is not correct.
Comment 1 Pavel Feldman 2009-09-26 11:39:22 PDT 
Created attachment 40176 [details]
patch
Comment 2 Pavel Feldman 2009-09-27 02:19:30 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorDOMStorageResource.cpp
Committed r48799