Bug 29769 - Web Inspector: Do not track DOM changes while inspector window is closed.
Summary: Web Inspector: Do not track DOM changes while inspector window is closed.
Status: RESOLVED DUPLICATE of bug 28903
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-26 11:25 PDT by Pavel Feldman
Modified: 2009-09-27 00:02 PDT (History)
1 user (show)

See Also:


Attachments
patch (6.79 KB, patch)
2009-09-26 11:32 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-09-26 11:25:57 PDT
- There is no need to track DOM changes while inspector window is hidden. This is different from the way it was working before the dom agent refactoring.
- There is a following bug:
1. Open web inspector for some page
2. Close web inspector
3. Reload the page
4. Open web inspector

Expected: Elements panel showing the DOM tree
Actual: Empty panel

The reason for a bug is that page reload pushes document's representation into the frontend and calls ElementsPanel's refresh. ElementsPanel is trying to be smart and is not processing refreshes while inspector window is hidden. Keeping dom agent operational only while inspector is visible solves both problems.
Comment 1 Pavel Feldman 2009-09-26 11:32:00 PDT
Created attachment 40175 [details]
patch

Note that I needed to restore WebCore::InspectorController::inspectedWindowScriptObjectCleared callback in order to clear injected script properly.
Comment 2 Timothy Hatcher 2009-09-26 12:49:35 PDT
Sounds like bug 28903.
Comment 3 Pavel Feldman 2009-09-27 00:02:44 PDT

*** This bug has been marked as a duplicate of bug 28903 ***