RESOLVED FIXED297485
webkitscmpy.local.git.Git.branch shouldn't call git-status 
https://bugs.webkit.org/show_bug.cgi?id=297485
Summary webkitscmpy.local.git.Git.branch shouldn't call git-status
Sam Sneddon [:gsnedders]
Reported 2025-08-15 15:03:56 PDT
This is: https://github.com/WebKit/WebKit/blob/42ff38fd1cc95732e666dd3ea2c0c599892e9118/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py#L482-L486 If we're only interested in "is this a detached head", we probably should just call `git symbolic-ref -q HEAD`, as it is (locally, on my current WebKit working copy) 150x quicker (4ms instead of 600ms).
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-08-15 15:04:05 PDT
<rdar://problem/158438687>
Ryan Haddad
Comment 2 2025-10-09 16:03:34 PDT
Pull request: https://github.com/WebKit/WebKit/pull/52090
EWS
Comment 3 2025-10-15 15:50:47 PDT
Committed 301587@main (32c25bb712d4): <https://commits.webkit.org/301587@main> Reviewed commits have been landed. Closing PR #52090 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.