Bug 29746 - Early returns in FrameLoader::loadURL harmful for plug-ins
Summary: Early returns in FrameLoader::loadURL harmful for plug-ins
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-25 13:04 PDT by Adam Barth
Modified: 2011-07-27 10:42 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-09-25 13:04:10 PDT
Comment #6 From Darin Fisher (:fishd, Google) 2009-09-21 00:32:42 PDT (-) [reply] 
I think these early returns are problematic for callers of
NPN_Get/PostURLNotify that expect a callback on success _or_ failure.  By
suppressing the frame loader notifications, the NPP_URLNotify call will be
suppressed, and that may result in memory leaks in the plugin.  (Note: This is
actually only a problem for Chrome since WebKit's plugin implementation has a
bug where it always fires NPP_URLNotify before the load completes.)

I believe the correct solution to this bug is to call
FrameLoaderClient::dispatchDidFailProvisionalLoad somehow instead of just
silently failing the loadURL / loadWithDocumentLoader calls.

Note: It looks like FrameLoader::loadURL has other early returns that could
cause similar problems.