Comment #6 From Darin Fisher (:fishd, Google) 2009-09-21 00:32:42 PDT (-) [reply]
I think these early returns are problematic for callers of
NPN_Get/PostURLNotify that expect a callback on success _or_ failure. By
suppressing the frame loader notifications, the NPP_URLNotify call will be
suppressed, and that may result in memory leaks in the plugin. (Note: This is
actually only a problem for Chrome since WebKit's plugin implementation has a
bug where it always fires NPP_URLNotify before the load completes.)
I believe the correct solution to this bug is to call
FrameLoaderClient::dispatchDidFailProvisionalLoad somehow instead of just
silently failing the loadURL / loadWithDocumentLoader calls.
Note: It looks like FrameLoader::loadURL has other early returns that could
cause similar problems.