RESOLVED FIXED 29743
Add a sqlite3_io_methods finder to Chromium's POSIX VFS
https://bugs.webkit.org/show_bug.cgi?id=29743
Summary Add a sqlite3_io_methods finder to Chromium's POSIX VFS
Dumitru Daniliuc
Reported 2009-09-25 11:29:08 PDT
The code that registers Chromium's POSIX VFS has a bug: it doesn't specify a sqlite3_io_methods finder. This can result in a crash.
Attachments
patch (1.59 KB, patch)
2009-09-25 11:37 PDT, Dumitru Daniliuc
dglazkov: review+
dglazkov: commit-queue-
patch (2.00 KB, patch)
2009-09-25 18:17 PDT, Dumitru Daniliuc
dglazkov: review+
commit-queue: commit-queue-
patch (2.00 KB, patch)
2009-09-27 18:20 PDT, Dumitru Daniliuc
no flags
Dumitru Daniliuc
Comment 1 2009-09-25 11:37:52 PDT
Created attachment 40128 [details] patch Please do NOT commit-queue+ this patch.
Dimitri Glazkov (Google)
Comment 2 2009-09-25 12:08:22 PDT
Comment on attachment 40128 [details] patch r=me.
Dumitru Daniliuc
Comment 3 2009-09-25 18:17:58 PDT
Created attachment 40157 [details] patch Same patch, but without requiring a change to the SQLite code. Please DO commit-queue+ this patch when you r+ it.
Dimitri Glazkov (Google)
Comment 4 2009-09-25 20:33:04 PDT
Comment on attachment 40157 [details] patch even better! r=me.
WebKit Commit Bot
Comment 5 2009-09-25 22:10:24 PDT
Comment on attachment 40157 [details] patch Rejecting patch 40157 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11332 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8966 tests run. 247.85s total testing time 8965 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 6 2009-09-26 01:26:19 PDT
Comment on attachment 40157 [details] patch Flakey test. Bug 29322.
WebKit Commit Bot
Comment 7 2009-09-26 07:52:36 PDT
Comment on attachment 40157 [details] patch Rejecting patch 40157 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11332 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8966 tests run. 251.00s total testing time 8965 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Dimitri Glazkov (Google)
Comment 8 2009-09-26 07:56:13 PDT
Comment on attachment 40157 [details] patch Let's spin again.
Eric Seidel (no email)
Comment 9 2009-09-26 11:03:02 PDT
That's bug 29322. I have a patch up for review to skip the test due to these types of failures. :(
Eric Seidel (no email)
Comment 10 2009-09-26 11:38:38 PDT
The commit-queue got stuck on this patch because of a programming error (calling error() instead of using ScriptError to return the failure). It will shortly be rejecting this patch due to an extra character before the date line in the WebCore ChangeLog. The extra '[' will need to be removed for someone to land this. (Or an updated patch can be posted and the commit-queue can land it.)
WebKit Commit Bot
Comment 11 2009-09-26 11:47:30 PDT
Comment on attachment 40157 [details] patch Rejecting patch 40157 from commit-queue. Failed to parse ChangeLog: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog
Dumitru Daniliuc
Comment 12 2009-09-27 18:20:24 PDT
Created attachment 40209 [details] patch Remove the '[' in WebCore/ChangeLog. Sorry about that typo...
Dumitru Daniliuc
Comment 13 2009-09-28 12:52:53 PDT
Comment on attachment 40209 [details] patch Testing the ability to post "reviews" for a patch. Please ignore.
Dimitri Glazkov (Google)
Comment 14 2009-09-28 15:19:29 PDT
Comment on attachment 40209 [details] patch one more time.
WebKit Commit Bot
Comment 15 2009-09-28 16:18:22 PDT
Comment on attachment 40209 [details] patch Rejecting patch 40209 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11339 test cases. fast/workers/dedicated-worker-lifecycle.html -> failed Exiting early after 1 failures. 8221 tests run. 172.19s total testing time 8220 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 16 2009-09-28 16:19:51 PDT
Comment on attachment 40209 [details] patch We're having no luck here. Now you hit bug 29344! Damn flakey tests!
WebKit Commit Bot
Comment 17 2009-09-28 16:33:32 PDT
Comment on attachment 40209 [details] patch Clearing flags on attachment: 40209 Committed r48845: <http://trac.webkit.org/changeset/48845>
WebKit Commit Bot
Comment 18 2009-09-28 16:33:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.