The code that registers Chromium's POSIX VFS has a bug: it doesn't specify a sqlite3_io_methods finder. This can result in a crash.
Created attachment 40128 [details] patch Please do NOT commit-queue+ this patch.
Comment on attachment 40128 [details] patch r=me.
Created attachment 40157 [details] patch Same patch, but without requiring a change to the SQLite code. Please DO commit-queue+ this patch when you r+ it.
Comment on attachment 40157 [details] patch even better! r=me.
Comment on attachment 40157 [details] patch Rejecting patch 40157 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11332 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8966 tests run. 247.85s total testing time 8965 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Comment on attachment 40157 [details] patch Flakey test. Bug 29322.
Comment on attachment 40157 [details] patch Rejecting patch 40157 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11332 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8966 tests run. 251.00s total testing time 8965 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Comment on attachment 40157 [details] patch Let's spin again.
That's bug 29322. I have a patch up for review to skip the test due to these types of failures. :(
The commit-queue got stuck on this patch because of a programming error (calling error() instead of using ScriptError to return the failure). It will shortly be rejecting this patch due to an extra character before the date line in the WebCore ChangeLog. The extra '[' will need to be removed for someone to land this. (Or an updated patch can be posted and the commit-queue can land it.)
Comment on attachment 40157 [details] patch Rejecting patch 40157 from commit-queue. Failed to parse ChangeLog: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog
Created attachment 40209 [details] patch Remove the '[' in WebCore/ChangeLog. Sorry about that typo...
Comment on attachment 40209 [details] patch Testing the ability to post "reviews" for a patch. Please ignore.
Comment on attachment 40209 [details] patch one more time.
Comment on attachment 40209 [details] patch Rejecting patch 40209 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11339 test cases. fast/workers/dedicated-worker-lifecycle.html -> failed Exiting early after 1 failures. 8221 tests run. 172.19s total testing time 8220 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output
Comment on attachment 40209 [details] patch We're having no luck here. Now you hit bug 29344! Damn flakey tests!
Comment on attachment 40209 [details] patch Clearing flags on attachment: 40209 Committed r48845: <http://trac.webkit.org/changeset/48845>
All reviewed patches have been landed. Closing bug.