Bug 29738 - Revert JavaScriptCore RefPtr and PassRefPtr changes when winscw bug gets fixed.
Summary: Revert JavaScriptCore RefPtr and PassRefPtr changes when winscw bug gets fixed.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Emulator S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 28054 29187
Blocks: 27065
  Show dependency treegraph
 
Reported: 2009-09-25 08:28 PDT by Yongjun Zhang
Modified: 2022-09-18 17:10 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2009-09-25 08:28:10 PDT
In RefPtr and PassRefPtr, a helper function is introduced (derefIfNotNull) to get around a known Winscw bug (https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812).

The change should be reverted if the above mentioned bug is fixed in winscw compiler side.

Following patches are introduced into JavascriptCore:

https://bugs.webkit.org/show_bug.cgi?id=28054
https://bugs.webkit.org/show_bug.cgi?id=29187
Comment 1 Ahmad Saleem 2022-09-17 16:56:03 PDT
PassRefPtr does not exist in Webkit Github source as of today. So this will be WONTFIX at this point. Thanks!
Comment 2 Alexey Proskuryakov 2022-09-18 17:10:55 PDT
We still have derefIfNotNull in RefPtr though. Also in CheckedPtr.

But it has changed, and I'm not sure if there is anything to do at this point.