Bug 29734 - Enable Pasteboard::writePlainText for Chromium and fix code style nits
Summary: Enable Pasteboard::writePlainText for Chromium and fix code style nits
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-09-25 03:59 PDT by Alexander Pavlov (apavlov)
Modified: 2009-09-25 08:48 PDT (History)
3 users (show)

See Also:

patch (5.60 KB, patch)
2009-09-25 06:36 PDT, Alexander Pavlov (apavlov)
mitz: review-
Details | Formatted Diff | Diff
patch (condition fixed) (5.60 KB, patch)
2009-09-25 07:24 PDT, Alexander Pavlov (apavlov)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2009-09-25 03:59:52 PDT
The associated patch shall uncomment the method body for the Chromium platform (introduced in https://bugs.webkit.org/show_bug.cgi?id=29634) now that the necessary Chromium repository change is in place, and fix some leftover style nits.
Comment 1 Alexander Pavlov (apavlov) 2009-09-25 06:36:41 PDT
Created attachment 40108 [details]
Comment 2 mitz 2009-09-25 07:09:22 PDT
Comment on attachment 40108 [details]

> -    if (types == nil) {
> +    if (!types == nil) {

This is wrong. I think you meant to change (types == nil) to (!types).
Comment 3 Alexander Pavlov (apavlov) 2009-09-25 07:24:38 PDT
Created attachment 40110 [details]
patch (condition fixed)

Apologies, I somehow failed to delete the rest of the condition. This is now fixed.
Comment 4 Pavel Feldman 2009-09-25 08:48:11 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/chromium/PasteboardChromium.cpp
	M	WebCore/platform/gtk/PasteboardGtk.cpp
	M	WebCore/platform/mac/PasteboardMac.mm
	M	WebCore/platform/qt/PasteboardQt.cpp
Committed r48755