Bug 29726 - Popup menus in Mac Chromium do not register the users selection
Summary: Popup menus in Mac Chromium do not register the users selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-24 16:17 PDT by Paul Godavari
Modified: 2009-09-25 09:23 PDT (History)
1 user (show)

See Also:

Attachments
Patch to fix Mac Chromium popup menu regression. (1.54 KB, patch)
2009-09-24 16:24 PDT, Paul Godavari 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Godavari 2009-09-24 16:17:43 PDT 
This is a regression caused by: http://trac.webkit.org/changeset/48642
Comment 1 Paul Godavari 2009-09-24 16:24:52 PDT 
Created attachment 40090 [details]
Patch to fix Mac Chromium popup menu regression.
Comment 2 Eric Seidel (no email) 2009-09-24 16:39:23 PDT 
Comment on attachment 40090 [details]
Patch to fix Mac Chromium popup menu regression.

OK. Code change looks fine, but how do we test this?  manual tests are OK.  They go in WebCore/manual-tests/
Comment 3 Paul Godavari 2009-09-24 16:43:41 PDT 
There's already a manual popup menu test that I created:
WebCore/manual-tests/select-narrow-width.html

Note: this is a P0 release blocker for Mac Chromium.
Comment 4 WebKit Commit Bot 2009-09-25 09:23:13 PDT 
Comment on attachment 40090 [details]
Patch to fix Mac Chromium popup menu regression.

Clearing flags on attachment: 40090

Committed r48757: <http://trac.webkit.org/changeset/48757>
Comment 5 WebKit Commit Bot 2009-09-25 09:23:16 PDT 
All reviewed patches have been landed.  Closing bug.