Bug 29725 - Add ARM version detection rules for Symbian
Summary: Add ARM version detection rules for Symbian
Status: RESOLVED DUPLICATE of bug 29715
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-09-24 15:28 PDT by Laszlo Gombos
Modified: 2009-09-24 15:44 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (1.56 KB, patch)
2009-09-24 15:36 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-09-24 15:28:20 PDT
Platform.h has a set of rules to detect ARM HW version. The detection rules seems to be specific (to GCC) and does not work for Symbian. A patch will follow to add the appropriate Symbian defines to detect ARM HW version using the Symbian toolchain.

Without this change the Symbian build would fail since the compiler would hit #error "Not supported ARM architecture", which was recently added (see http://trac.webkit.org/changeset/48525)
Comment 1 Laszlo Gombos 2009-09-24 15:36:46 PDT
Created attachment 40086 [details]
proposed patch
Comment 2 Laszlo Gombos 2009-09-24 15:40:08 PDT
Comment on attachment 40086 [details]
proposed patch

cancel the review as this is a dup of bug 29715; will upload this patch there for review.
Comment 3 Laszlo Gombos 2009-09-24 15:44:49 PDT

*** This bug has been marked as a duplicate of bug 29715 ***