Bug 29723 - Division is needlessly slow in 64-bit
Summary: Division is needlessly slow in 64-bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-24 15:14 PDT by Oliver Hunt
Modified: 2009-09-24 19:44 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (11.37 KB, patch)
2009-09-24 15:16 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch v1 (12.51 KB, patch)
2009-09-24 17:24 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch v1 (12.21 KB, patch)
2009-09-24 17:38 PDT, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-09-24 15:14:50 PDT
it needs to have real codegen
Comment 1 Oliver Hunt 2009-09-24 15:16:45 PDT
Created attachment 40084 [details]
Patch v1
Comment 2 Geoffrey Garen 2009-09-24 15:36:58 PDT
Comment on attachment 40084 [details]
Patch v1

As I said on IRC, I think you should copy JSVALUE32_64, and convert back to int at the end in all cases other than 1/x. See JITArithmetic.cpp:992.
Comment 3 Gavin Barraclough 2009-09-24 15:43:26 PDT
Variable names j1 j11 j2 j22 ain't up to scratch, let's make them a little more descriptive.
Please add the runtime assert as described to the slowcase.
Comment 4 Oliver Hunt 2009-09-24 17:24:08 PDT
Created attachment 40094 [details]
Patch v1
Comment 5 Oliver Hunt 2009-09-24 17:38:02 PDT
Created attachment 40095 [details]
Patch v1
Comment 6 Oliver Hunt 2009-09-24 19:44:37 PDT
Committed r48744