Compiling a debug chromium with a webcore that doesn't have debug symbols cuts the output binary from ~750mb to ~350mb. This speeds up the compile and reduces the gdb startup time considerably. It would be nice to have a gyp variable for this.
Created attachment 40078 [details] v1
Mark: Can you take a look at this change?
Comment on attachment 40078 [details] v1 This change looks good to me, but you should be aware that it won't be effective on the Mac, because we don't turn on debugging symbols by setting cflags.
I'm somewhat surprised that Bugzilla allowed me to formally r+ this, since I'm not a WebKit reviewer. I'm not sure what WebKit reviewer would be appropriate here though. I just mention this so that you can cover your bases.
Comment on attachment 40078 [details] v1 Changing back to r? so I can r+ it.
Comment on attachment 40078 [details] v1 r=me (since Mark said it looked good.) I'll leave the cq?. Tony since you are a committer you can change it to cq+ if you want to try to use the auto-commit thing.
Comment on attachment 40078 [details] v1 Let's try the auto committer.
Comment on attachment 40078 [details] v1 Rejecting patch 40078 from commit-queue. tony@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment on attachment 40078 [details] v1 Looks like tony hasn't added himself to the committers.py file yet.
Comment on attachment 40078 [details] v1 Was this diff edited by hand? It failed to apply correctly... See attachment on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log.
(In reply to comment #10) > (From update of attachment 40078 [details]) > Was this diff edited by hand? It failed to apply correctly... See attachment > on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log. I made the diff using "git diff --no-prefix --relative". I guess I should just use git-bugzilla-tool.
Will land manually.
Landed.
Changed by: agl@chromium.org Changed at: Fri 25 Sep 2009 16:19:03 Branch: trunk Revision: 48777 Changed files: WebCore/ChangeLog WebCore/WebCore.gyp/WebCore.gyp Comments: 2009-09-24 Tony Chang <tony@chromium.org> Reviewed by David Levin. Add a gyp variable to allow building a debug webcore without debug symbols. This allows for faster compile, link, and gdb times. https://bugs.webkit.org/show_bug.cgi?id=29721 No new tests, build config change. * WebCore.gyp/WebCore.gyp: Properties: