Bug 29721 - add a gyp variable to allow compiling webcore without debug symbols
Summary: add a gyp variable to allow compiling webcore without debug symbols
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Adam Langley
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-24 12:09 PDT by Tony Chang
Modified: 2009-09-25 16:20 PDT (History)
3 users (show)

See Also:


Attachments
v1 (1.49 KB, patch)
2009-09-24 12:29 PDT, Tony Chang
levin: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2009-09-24 12:09:09 PDT
Compiling a debug chromium with a webcore that doesn't have debug symbols cuts the output binary from ~750mb to ~350mb.  This speeds up the compile and reduces the gdb startup time considerably.

It would be nice to have a gyp variable for this.
Comment 1 Tony Chang 2009-09-24 12:29:17 PDT
Created attachment 40078 [details]
v1
Comment 2 Tony Chang 2009-09-24 14:02:20 PDT
Mark: Can you take a look at this change?
Comment 3 Mark Mentovai 2009-09-24 14:04:20 PDT
Comment on attachment 40078 [details]
v1

This change looks good to me, but you should be aware that it won't be effective on the Mac, because we don't turn on debugging symbols by setting cflags.
Comment 4 Mark Mentovai 2009-09-24 14:05:36 PDT
I'm somewhat surprised that Bugzilla allowed me to formally r+ this, since I'm not a WebKit reviewer.  I'm not sure what WebKit reviewer would be appropriate here though.  I just mention this so that you can cover your bases.
Comment 5 David Levin 2009-09-24 14:06:50 PDT
Comment on attachment 40078 [details]
v1

Changing back to r? so I can r+ it.
Comment 6 David Levin 2009-09-24 14:08:29 PDT
Comment on attachment 40078 [details]
v1

r=me (since Mark said it looked good.)

I'll leave the cq?. Tony since you are a committer you can change it to cq+ if you want to try to use the auto-commit thing.
Comment 7 Tony Chang 2009-09-24 14:12:05 PDT
Comment on attachment 40078 [details]
v1

Let's try the auto committer.
Comment 8 WebKit Commit Bot 2009-09-24 14:19:17 PDT
Comment on attachment 40078 [details]
v1

Rejecting patch 40078 from commit-queue.

tony@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 9 Eric Seidel (no email) 2009-09-24 14:38:19 PDT
Comment on attachment 40078 [details]
v1

Looks like tony hasn't added himself to the committers.py file yet.
Comment 10 Eric Seidel (no email) 2009-09-24 15:05:31 PDT
Comment on attachment 40078 [details]
v1

Was this diff edited by hand?  It failed to apply correctly...  See attachment on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log.
Comment 11 Tony Chang 2009-09-24 15:19:06 PDT
(In reply to comment #10)
> (From update of attachment 40078 [details])
> Was this diff edited by hand?  It failed to apply correctly...  See attachment
> on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log.

I made the diff using "git diff --no-prefix --relative".  I guess I should just use git-bugzilla-tool.
Comment 12 Adam Langley 2009-09-25 16:08:41 PDT
Will land manually.
Comment 13 Adam Langley 2009-09-25 16:19:33 PDT
Landed.
Comment 14 Adam Langley 2009-09-25 16:20:15 PDT
Changed by: agl@chromium.org
Changed at: Fri 25 Sep 2009 16:19:03
Branch: trunk
Revision: 48777

Changed files:

WebCore/ChangeLog
WebCore/WebCore.gyp/WebCore.gyp
Comments:
2009-09-24  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        Add a gyp variable to allow building a debug webcore without debug
        symbols.  This allows for faster compile, link, and gdb times.

        https://bugs.webkit.org/show_bug.cgi?id=29721

        No new tests, build config change.

        * WebCore.gyp/WebCore.gyp:
Properties: