Bug 29718 – mark-bug-fixed: add -u|--update-only switch

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Created attachment 40072 [details]
Patch v1

Reviewed by NOBODY (OOPS!).

* Scripts/mark-bug-fixed:
(MarkBugFixed.__init__): Added -u|--update-only switch to list
of parse options.
(MarkBugFixed.main): When -u|--update-only is specified, add a
comment to the bug without marking it Resolved/Fixed.
---
 2 files changed, 19 insertions(+), 2 deletions(-)

[Eric Seidel (no email)]

I think this is kinda a strange command-line API (calling mark-as-fixed but not having it mark anything as fixed), but I like the functionality.  An Apple person would have to comment as to if this makes sense for y'alls workflow.

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> I think this is kinda a strange command-line API (calling mark-as-fixed but not
> having it mark anything as fixed), but I like the functionality.  An Apple
> person would have to comment as to if this makes sense for y'alls workflow.

This is useful if you have more than one patch that is required to fix a bug, but don't want to close the bug after the first commit.

Some folks like to commit fixes to individual directories separately (one for WebCore, one for LayoutTests), which makes this flag useful as well.

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> This is useful if you have more than one patch that is required to fix a bug,
> but don't want to close the bug after the first commit.

I don't see why creating a second script would be helpful in this case.  (The most common workflow is to mark the bug as fixed, but you use the same script to update it as well.)

Do you have another suggestion for the script's name?  I did not want to use "update-bug" since there are too many update-* scripts already.  :)

> Some folks like to commit fixes to individual directories separately (one for
> WebCore, one for LayoutTests), which makes this flag useful as well.

BTW, I don't condone this workflow.

[Eric Seidel (no email)]

Comment on attachment 40072 [details]
Patch v1

OK.  You might want to make clear in the -u help that it will add the fixed revision to the bug as well, not just the comment you pass in -m.  I think that was my initial confusion is that I thought you had effectively created a "add-comment" command, but now I see that this is still really a "mark-bug-with-revision" behavior even if it doesn't always close the bug.

[David Kilzer (:ddkilzer)]

Committed r48772: <http://trac.webkit.org/changeset/48772>