Bug 29716 – [GTK] re-enable some media tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

It looks harmless to me to re-enable some of the media tests. The one related to canPlayType() needs a little adjustment in the gstreamers backend though. Attaching patch.

[Philippe Normand]

Created attachment 40069 [details]
proposed patch

[Philippe Normand]

Created attachment 40071 [details]
proposed patch (without white spaces in ChangeLog)

[Gustavo Noronha (kov)]

Comment on attachment 40071 [details]
proposed patch (without white spaces in ChangeLog)

OK, a couple nits:

> +        [GTK] re-enable some media tests
> +        https://bugs.webkit.org/show_bug.cgi?id=29716
> +
> +        make canPlayType() return "probably" if mime-type is known
> +        and codecs string is not empty. If codecs is empty return
> +        "maybe".
> +        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
> +        (WebCore::MediaPlayerPrivate::duration):
> +

This is refering to duration, but you only touch supportsType. Maybe it was incorrectly generated by prepare-ChangeLogs, but may be worth fixing. Also, I think you want a blank line between the message and the list of files. I'll ask that you upload a new patch just because I am lazy and want to use the commit bot =).

[Gustavo Noronha (kov)]

Comment on attachment 40071 [details]
proposed patch (without white spaces in ChangeLog)

I will actually fix the nits myself, and land.

[Xan Lopez]

This was landed in r48724, closing.