WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29716
[GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716
Summary
[GTK] re-enable some media tests
Philippe Normand
Reported
2009-09-24 09:10:47 PDT
It looks harmless to me to re-enable some of the media tests. The one related to canPlayType() needs a little adjustment in the gstreamers backend though. Attaching patch.
Attachments
proposed patch
(3.23 KB, patch)
2009-09-24 09:19 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
proposed patch (without white spaces in ChangeLog)
(3.25 KB, patch)
2009-09-24 09:24 PDT
,
Philippe Normand
gustavo
: review+
gustavo
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2009-09-24 09:19:49 PDT
Created
attachment 40069
[details]
proposed patch
Philippe Normand
Comment 2
2009-09-24 09:24:53 PDT
Created
attachment 40071
[details]
proposed patch (without white spaces in ChangeLog)
Gustavo Noronha (kov)
Comment 3
2009-09-24 10:08:52 PDT
Comment on
attachment 40071
[details]
proposed patch (without white spaces in ChangeLog) OK, a couple nits:
> + [GTK] re-enable some media tests > +
https://bugs.webkit.org/show_bug.cgi?id=29716
> + > + make canPlayType() return "probably" if mime-type is known > + and codecs string is not empty. If codecs is empty return > + "maybe". > + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: > + (WebCore::MediaPlayerPrivate::duration): > +
This is refering to duration, but you only touch supportsType. Maybe it was incorrectly generated by prepare-ChangeLogs, but may be worth fixing. Also, I think you want a blank line between the message and the list of files. I'll ask that you upload a new patch just because I am lazy and want to use the commit bot =).
Gustavo Noronha (kov)
Comment 4
2009-09-24 10:29:47 PDT
Comment on
attachment 40071
[details]
proposed patch (without white spaces in ChangeLog) I will actually fix the nits myself, and land.
Xan Lopez
Comment 5
2009-09-24 22:30:58 PDT
This was landed in
r48724
, closing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug