RESOLVED FIXED 29707
Web Inspector: Color-code watch expression errors with red. 
https://bugs.webkit.org/show_bug.cgi?id=29707
Summary Web Inspector: Color-code watch expression errors with red.
Pavel Feldman
Reported 2009-09-24 02:12:16 PDT
Reference and parse errors are currently rendered as black plain strings.
Attachments
patch (2.38 KB, patch)
2009-09-24 02:17 PDT, Pavel Feldman 		timothy: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-09-24 02:17:14 PDT
Created attachment 40054 [details] patch
Patrick Mueller
Comment 2 2009-09-24 06:29:47 PDT
It would probably be useful to have this in ObjectProperties* bits instead of just the WatchExpressiosn. So that if I'm in a catch block, I'll see my exception in the locals as red. Or if I happen to have some other local variable or object property which is holding onto an exception for some reason, it would also go red. See also: bug 27235
Timothy Hatcher
Comment 3 2009-09-24 07:25:11 PDT
Red might mean "changed" since last step, like in Xcode too. So I'm not sure this should be universal thing for ObjectPropertiesSection.
Patrick Mueller
Comment 4 2009-09-24 07:47:23 PDT
That's fine for now. As we implement bug 27235, maybe we'll find a better holistic approach. w/r/t "changed since last step", I suppose we should open a bug up on that. So I just did, as bug 29714
Eric Seidel (no email)
Comment 5 2009-09-29 14:12:43 PDT
Comment on attachment 40054 [details] patch I think svn-apply would get confused by this ChangeLog, so marking cq-. Besides Pavel is a committer. :)
Pavel Feldman
Comment 6 2009-09-29 14:24:17 PDT
Landed as r48718.
Note You need to log in before you can comment on or make changes to this bug.