Bug 29705 - Web Inspector: Fix formatting for messages derived from resource warnings, couple of drive-by fixes.
Summary: Web Inspector: Fix formatting for messages derived from resource warnings, co...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-09-24 01:02 PDT by Pavel Feldman
Modified: 2009-09-24 04:58 PDT (History)
2 users (show)

See Also:

patch (6.24 KB, patch)
2009-09-24 01:05 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
same with watch abbreviation (6.12 KB, patch)
2009-09-24 02:09 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-09-24 01:02:20 PDT
For watch panel, console and properties section to use the same code, we wrap all the result of the evaluation (even in case of primitive values). However, WebInspector's addMessage API is also used from within frontend (for resource warnings). This should be resolved. The patch also has a handful of drive-by fixes.
Comment 1 Pavel Feldman 2009-09-24 01:05:49 PDT
Created attachment 40050 [details]
Comment 2 Pavel Feldman 2009-09-24 02:09:31 PDT
Created attachment 40053 [details]
same with watch abbreviation
Comment 3 Pavel Feldman 2009-09-24 04:58:05 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/WatchExpressionsSidebarPane.js
Committed r48717