Bug 297045 – [LegacySVG] Don't check 'visibility' in LegacyRenderSVGResourceMasker

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across another potential merge, where only in LegacySVG - we have this bug:

Test Case: https://jsfiddle.net/L3nqvrsc/

^ Passes in Chrome Canary 141 and Firefox Nightly 143, fails on Safari Technology Preview 225 + WebKit ToT (298320@main). It passes with LBSE.

Blink Commit: https://chromium.googlesource.com/chromium/src/+/51a75fa55ba71462963ddcf085995cf3eca66104

WebKit Source: https://searchfox.org/wubkat/rev/c0e84bbc88a4c382789dea06bdead904860b6e8c/Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp#146

Remove - || style->usedVisibility() != Visibility::Visible

https://searchfox.org/wubkat/rev/c0e84bbc88a4c382789dea06bdead904860b6e8c/Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp#170


void LegacyRenderSVGResourceMasker::calculateMaskContentRepaintRect(RepaintRectCalculation repaintRectCalculation)
{
    Ref maskElement = this->maskElement();
    for (auto& child : childrenOfType<SVGElement>(maskElement)) {
        CheckedPtr renderer = child.renderer();
        if (!renderer)
            continue;
        const CheckedRef style = renderer->style();
        if (style->display() == DisplayType::None)
            continue;

        m_maskContentBoundaries[repaintRectCalculation].unite(renderer->localToParentTransform().mapRect(renderer->repaintRectInLocalCoordinates(repaintRectCalculation)));
    }
}

Use for-range loop like other and update it.

___________________________

Just raising so we can fix it. Above does fix it.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/157729389>

[Ahmad Saleem]

Pull request: https://github.com/WebKit/WebKit/pull/55990

[EWS]

Committed 305047@main (bda153efaee1): <https://commits.webkit.org/305047@main>

Reviewed commits have been landed. Closing PR #55990 and removing active labels.