Bug 29694 - WebCore side of changes to remove gfx::Rect dependency from ImageSkia
Summary: WebCore side of changes to remove gfx::Rect dependency from ImageSkia
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-23 14:07 PDT by Peter Kasting
Modified: 2009-09-23 14:19 PDT (History)
0 users

See Also:

Attachments
patch v1 (3.11 KB, patch)
2009-09-23 14:09 PDT, Peter Kasting 		dglazkov: review+
dglazkov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2009-09-23 14:07:06 PDT 
The Chromium WebCore code should not rely on types in the Chromium repository like gfx::Rect.  This bug is for the WebCore side of a change to remove one such dependency; I also need to land a simultaneous Chromium change once this is committed.
Comment 1 Peter Kasting 2009-09-23 14:09:24 PDT 
Created attachment 40016 [details]
patch v1
Comment 2 Dimitri Glazkov (Google) 2009-09-23 14:13:49 PDT 
Comment on attachment 40016 [details]
patch v1

r=me, with nits:

> +        https://bugs.webkit.org/show_bug.cgi?id=29694
> +        Eliminate dependency on gfx::Rect from ImageSkia.

pls put [Chromium] in front of the description.

> -    SkIRect resizedImageRect;  // Represents the size of the resized image.
> -    resizedImageRect.set(0, 0, destRectRounded.width(), destRectRounded.height());
> +    SkIRect resizedImageRect =  // Represents the size of the resized image.
> +        { 0, 0, destRectRounded.width(), destRectRounded.height() };

This looks a bit weird, but ok.
Comment 3 Peter Kasting 2009-09-23 14:19:13 PDT 
Fixed in r48684.