The Qt implementation of the clipOut family of methods on GraphicsContext, instead of clipping out the intended area clip it in if clipping was not enabled prior to the call. This leads to shadows being rendered incorrectly in some QtWebKit based applications that use an unclipped painter when calling QWebFrame::paintContent.
Patch comming later today.
Created attachment 40024 [details] Proposed patch This patch handles the case when no clipping is set by the user of QtWebKit.
I'm not a reviewer but you forgot to delete QRectF clipBounds = p->clipPath().boundingRect(); in GC::clipOut(). I don't know what to do if p doesn't have clipping. Maybe torarne or ariya are the right person to review the patch.
Created attachment 40113 [details] Proposed Patch: Fixed a minor issue highlighted by Dirk (see comments). Fixed a minor issue highlighted by Dirk (see comments).
Created attachment 40516 [details] Proposed Patch Fixed style issue pointed out by Dirk
(In reply to comment #5) > Created an attachment (id=40516) [details] > Proposed Patch > > Fixed style issue pointed out by Dirk The code style as well as the fix itself look good to me. I would say r+, but I'm not a reviewer :-)
Comment on attachment 40516 [details] Proposed Patch Clearing flags on attachment: 40516 Committed r49195: <http://trac.webkit.org/changeset/49195>
All reviewed patches have been landed. Closing bug.