I'd like to see the HTTP version in the HTTP Information inspector details as implemented in http://trac.webkit.org/changeset/48646 HTTP Version is useful info because it affects resource download pipelining behaviour. Brian Weinstein says (https://bugs.webkit.org/show_bug.cgi?id=19945#c25): > this data is not easy to get from either a ResourceResponse or a > ResourceRequest, so it would take some big changes, and we would need some > information that I don't know if we have an API to get.
Yeah, good luck getting that data. :)
We absolutely want to ultimately show pipelining information in Web Inspector when we can get that information from the underlying network layer (different per-port). The next step is integrating the richer Network Timing information we have into Inspector.
<rdar://problem/19281586>
We included the protocol for Resource Timing with NetworkLoadMetrics. Exposing those and a few more metrics to Web Inspector.
Created attachment 303943 [details] [PATCH] Proposed Fix
Created attachment 303944 [details] [IMAGE] New Datagrid Columns
Comment on attachment 303943 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=303943&action=review > Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js:57 > columns.type.title = WebInspector.UIString("Type"); > - columns.type.width = "6%"; > + columns.type.width = "8%"; > > columns.method.title = WebInspector.UIString("Method"); > - columns.method.width = "5%"; > + columns.method.width = "6%"; > > columns.scheme.title = WebInspector.UIString("Scheme"); > - columns.scheme.width = "5%"; > + columns.scheme.width = "6%"; > > columns.statusCode.title = WebInspector.UIString("Status"); > - columns.statusCode.width = "5%"; > + columns.statusCode.width = "6%"; Errr, all of these numbers should not have changed. I'll change them back
Do we also show it when I select a specific resource, and look at the right sidebar where we show the MIME type, Location etc? That's where I'd expect to see it.
(In reply to comment #8) > Do we also show it when I select a specific resource, and look at the right > sidebar where we show the MIME type, Location etc? That's where I'd expect > to see it. We do not, I'll add that and put up another patch.
Created attachment 303988 [details] [IMAGE] Resources Details Sidebar
Created attachment 303989 [details] [PATCH] Proposed Fix
Comment on attachment 303989 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=303989&action=review > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:928 > + copy[columnIdentifier] = visible; This could be potentially improved so that if the new value is the default value we don't store anything for it. So something like: if (visible === !!originalColumnInfo.hidden) delete copy[columnIdentifier]; else copy[columnIdentifier] = visible; Let me know if you want me to try to move in that direction. I haven't checked if we have the "originalColumnInfo"
Created attachment 303992 [details] [PATCH] Proposed Fix
Comment on attachment 303992 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=303992&action=review > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:928 > + copy[columnIdentifier] = visible; This could be potentially improved so that if the new value is the default value we don't store anything for it. So something like: if (visible === !!originalColumnInfo.hidden) delete copy[columnIdentifier]; else copy[columnIdentifier] = visible; Let me know if you want me to try to move in that direction. I haven't checked if we have the "originalColumnInfo"
Comment on attachment 303992 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=303992&action=review >> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:928 >> + copy[columnIdentifier] = visible; > > This could be potentially improved so that if the new value is the default value we don't store anything for it. So something like: > > if (visible === !!originalColumnInfo.hidden) > delete copy[columnIdentifier]; > else > copy[columnIdentifier] = visible; > > Let me know if you want me to try to move in that direction. I haven't checked if we have the "originalColumnInfo" I like it. Filed follow-up: Web Inspector: Improve storing of DataGrid column visibility https://bugs.webkit.org/show_bug.cgi?id=169444
Comment on attachment 303992 [details] [PATCH] Proposed Fix Very nice! r=me. Although the SPI/networking changes are straightforward and appear correct, someone with more knowledge in that area should maybe have a look.
Comment on attachment 303992 [details] [PATCH] Proposed Fix r=me as well
<https://trac.webkit.org/changeset/213682>
Follow-up to avoid possible build issues regarding the SPI: <https://trac.webkit.org/changeset/213685> This workaround should be possible to remove shortly.