Bug 296738 – REGRESSION(297498@main): [WPE] build broken when using API 1.1

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Miguel Gomez]

The error is

/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp: In constructor ‘_WebKitJavascriptResult::_WebKitJavascriptResult(WebKit::JavaScriptEvaluationResult&&)’:
/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:39:19: error: invalid use of incomplete type ‘class WebKit::JavaScriptEvaluationResult’
   39 |         jsValue = result.toJSC();
      |                   ^~~~~~
In file included from /host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:26:
/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResultPrivate.h:26:7: note: forward declaration of ‘class WebKit::JavaScriptEvaluationResult’
   26 | class JavaScriptEvaluationResult;
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~
/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp: At global scope:
/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:49:54: error: ‘WebKitJavascriptResult* webkitJavascriptResultCreate’ redeclared as different kind of entity
   49 | WebKitJavascriptResult* webkitJavascriptResultCreate(WebCore::SerializedScriptValue& serializedScriptValue)
      |                                                      ^~~~~~~
/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResultPrivate.h:28:25: note: previous declaration ‘WebKitJavascriptResult* webkitJavascriptResultCreate(WebKit::JavaScriptEvaluationResult&&)’
   28 | WebKitJavascriptResult* webkitJavascriptResultCreate(WebKit::JavaScriptEvaluationResult&&);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:49:54: error: ‘WebCore’ has not been declared
   49 | WebKitJavascriptResult* webkitJavascriptResultCreate(WebCore::SerializedScriptValue& serializedScriptValue)
      |                                                      ^~~~~~~
/host/home/magomez/webkit/WebKit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:49:86: error: ‘serializedScriptValue’ was not declared in this scope
   49 | WebKitJavascriptResult* webkitJavascriptResultCreate(WebCore::SerializedScriptValue& serializedScriptValue)


and it happens because webkitJavascriptResultCreate was modified to receive a WebKit::JavaScriptEvaluationResult&& instead of a WebCore::SerializedScriptValue&, but this modification was done only in the function declaration. There's also missing include of JavaScriptEvaluationResult.h that can cause an unified build error.

[Miguel Gomez]

Pull request: https://github.com/WebKit/WebKit/pull/48770

[EWS]

Committed 298116@main (cc5fa20e86a3): <https://commits.webkit.org/298116@main>

Reviewed commits have been landed. Closing PR #48770 and removing active labels.

[Jim Mason]

Duplicate of Bug 296525.  Closing the older bug.