Bug 29673 - In profiler, call tree nodes expansion doesn't respect current sorting
Summary: In profiler, call tree nodes expansion doesn't respect current sorting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-23 01:02 PDT by Mikhail Naganov
Modified: 2009-10-20 16:10 PDT (History)
3 users (show)

See Also:

Attachments
Screenshot (39.23 KB, image/png)
2009-09-23 01:02 PDT, Mikhail Naganov 		no flags Details
proposed patch (13.73 KB, patch)
2009-10-17 07:02 PDT, Mikhail Naganov 		timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
a patch to submit: renamed doPopulate -> _shouldPopulate (13.78 KB, patch)
2009-10-20 15:54 PDT, Mikhail Naganov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2009-09-23 01:02:06 PDT 
Created attachment 39978 [details]
Screenshot

When expanding nodes of a call tree, children revealed are not sorted according to the current sorting column.

To reproduce:
- collect a profile;
- open it and sort data, say, by the "Calls" column, observe that items shown are sorted;
- now expand a node, observe that children shown are not sorted by the "Calls" column.

See the attached screenshot.

I'm planning to fix this issue.
Comment 1 Mikhail Naganov 2009-10-17 07:02:38 PDT 
Created attachment 41356 [details]
proposed patch

The patch may look big, but it's only because I swapped BottomUpProfileDataGridTree and Node declarations to be consistent with TopDownProfile.
Comment 2 Timothy Hatcher 2009-10-20 15:29:13 PDT 
Comment on attachment 41356 [details]
proposed patch

You should call doPopulate _sharedPopulate. Using an underscore since it is private.
Comment 3 Mikhail Naganov 2009-10-20 15:54:39 PDT 
Created attachment 41532 [details]
a patch to submit: renamed doPopulate -> _shouldPopulate
Comment 4 Mikhail Naganov 2009-10-20 15:58:29 PDT 
Ugh, the comment is wrong. I renamed doPopulate to _sharedPopulate, as Timothy proposes.
Comment 5 WebKit Commit Bot 2009-10-20 16:10:53 PDT 
Comment on attachment 41532 [details]
a patch to submit: renamed doPopulate -> _shouldPopulate

Clearing flags on attachment: 41532

Committed r49891: <http://trac.webkit.org/changeset/49891>
Comment 6 WebKit Commit Bot 2009-10-20 16:10:57 PDT 
All reviewed patches have been landed.  Closing bug.