WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29673
In profiler, call tree nodes expansion doesn't respect current sorting
https://bugs.webkit.org/show_bug.cgi?id=29673
Summary
In profiler, call tree nodes expansion doesn't respect current sorting
Mikhail Naganov
Reported
2009-09-23 01:02:06 PDT
Created
attachment 39978
[details]
Screenshot When expanding nodes of a call tree, children revealed are not sorted according to the current sorting column. To reproduce: - collect a profile; - open it and sort data, say, by the "Calls" column, observe that items shown are sorted; - now expand a node, observe that children shown are not sorted by the "Calls" column. See the attached screenshot. I'm planning to fix this issue.
Attachments
Screenshot
(39.23 KB, image/png)
2009-09-23 01:02 PDT
,
Mikhail Naganov
no flags
Details
proposed patch
(13.73 KB, patch)
2009-10-17 07:02 PDT
,
Mikhail Naganov
timothy
: review+
timothy
: commit-queue-
Details
Formatted Diff
Diff
a patch to submit: renamed doPopulate -> _shouldPopulate
(13.78 KB, patch)
2009-10-20 15:54 PDT
,
Mikhail Naganov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mikhail Naganov
Comment 1
2009-10-17 07:02:38 PDT
Created
attachment 41356
[details]
proposed patch The patch may look big, but it's only because I swapped BottomUpProfileDataGridTree and Node declarations to be consistent with TopDownProfile.
Timothy Hatcher
Comment 2
2009-10-20 15:29:13 PDT
Comment on
attachment 41356
[details]
proposed patch You should call doPopulate _sharedPopulate. Using an underscore since it is private.
Mikhail Naganov
Comment 3
2009-10-20 15:54:39 PDT
Created
attachment 41532
[details]
a patch to submit: renamed doPopulate -> _shouldPopulate
Mikhail Naganov
Comment 4
2009-10-20 15:58:29 PDT
Ugh, the comment is wrong. I renamed doPopulate to _sharedPopulate, as Timothy proposes.
WebKit Commit Bot
Comment 5
2009-10-20 16:10:53 PDT
Comment on
attachment 41532
[details]
a patch to submit: renamed doPopulate -> _shouldPopulate Clearing flags on attachment: 41532 Committed
r49891
: <
http://trac.webkit.org/changeset/49891
>
WebKit Commit Bot
Comment 6
2009-10-20 16:10:57 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug