RESOLVED FIXED296684
SharedBufferBuilder::take() should return a contiguous SharedBuffer if it only contains a single DataSegment. 
https://bugs.webkit.org/show_bug.cgi?id=296684
Summary SharedBufferBuilder::take() should return a contiguous SharedBuffer if it onl...
Jean-Yves Avenard [:jya]
Reported 2025-07-30 01:44:08 PDT
When we create a SharedBufferBuilder and only append a single segment to it, if we later call SharedBufferBuilder::take() what we get is a FragmentedSharedBuffer, it could be a SharedBuffer instead. Which would allow simplification later and remove unnecessary allocation when we then call getAsContiguous() on that SharedBuffer.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-07-30 01:47:36 PDT
<rdar://problem/157093750>
Jean-Yves Avenard [:jya]
Comment 2 2025-07-30 21:43:52 PDT
Pull request: https://github.com/WebKit/WebKit/pull/48760
EWS
Comment 3 2025-08-02 08:09:30 PDT
Committed 298168@main (a20b10db9c2d): <https://commits.webkit.org/298168@main> Reviewed commits have been landed. Closing PR #48760 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.