Bug 29661 – Vanilla build setup for Win32/Cairo build

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Marshall Culpepper]

There are a few minor problems holding back the Win32/Cairo port from building from a vanilla source tree:
- Both WebCoreCairo.vsprops and WebKitLibraries/win/tools/vsprops/WinCairo.vsprops doesn't include $(WebKitLibrariesDir)/include/cairo, causing both WebKit and DumpRenderTree to fail looking for cairo.h
- DumpRenderTree still looks for jpeg.lib as opposed to libjpeg.lib

Once these are fixed, we should be able to build Win32/Cairo by simply extracting the necessary libs/includes into the $WebKitLibraries folder, which is where the rest of the compile dependencies live.

[Marshall Culpepper]

Created attachment 39963 [details]
build patch

[Brent Fulgham]

This patch looks good to me.

[Marshall Culpepper]

Created attachment 39973 [details]
build patch #2

Looks like there's also a minor compile failure in DRT, the stub for setAlwaysAcceptCookies doesn't return anything when using cURL. Here's an updated patch.

[Eric Seidel (no email)]

Comment on attachment 39973 [details]
build patch #2

Ok.  LGTM.  I'm assuming you want this auto-committed since you're not a committer.  In the future be sure to set commit-queue=? if you want things auto-committed (or make other arrangements to have a committer land your patch for you.)  See http://webkit.org/coding/contributing.html.

[WebKit Commit Bot]

Comment on attachment 39973 [details]
build patch #2

Clearing flags on attachment: 39973

Committed r48692: <http://trac.webkit.org/changeset/48692>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.