Bug 29661 - Vanilla build setup for Win32/Cairo build
Summary: Vanilla build setup for Win32/Cairo build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-22 17:13 PDT by Marshall Culpepper
Modified: 2009-09-23 17:55 PDT (History)
2 users (show)

See Also:


Attachments
build patch (6.52 KB, patch)
2009-09-22 17:18 PDT, Marshall Culpepper
no flags Details | Formatted Diff | Diff
build patch #2 (7.17 KB, patch)
2009-09-22 18:45 PDT, Marshall Culpepper
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marshall Culpepper 2009-09-22 17:13:00 PDT
There are a few minor problems holding back the Win32/Cairo port from building from a vanilla source tree:
- Both WebCoreCairo.vsprops and WebKitLibraries/win/tools/vsprops/WinCairo.vsprops doesn't include $(WebKitLibrariesDir)/include/cairo, causing both WebKit and DumpRenderTree to fail looking for cairo.h
- DumpRenderTree still looks for jpeg.lib as opposed to libjpeg.lib

Once these are fixed, we should be able to build Win32/Cairo by simply extracting the necessary libs/includes into the $WebKitLibraries folder, which is where the rest of the compile dependencies live.
Comment 1 Marshall Culpepper 2009-09-22 17:18:30 PDT
Created attachment 39963 [details]
build patch
Comment 2 Brent Fulgham 2009-09-22 17:27:03 PDT
This patch looks good to me.
Comment 3 Marshall Culpepper 2009-09-22 18:45:14 PDT
Created attachment 39973 [details]
build patch #2

Looks like there's also a minor compile failure in DRT, the stub for setAlwaysAcceptCookies doesn't return anything when using cURL. Here's an updated patch.
Comment 4 Eric Seidel (no email) 2009-09-23 17:43:19 PDT
Comment on attachment 39973 [details]
build patch #2

Ok.  LGTM.  I'm assuming you want this auto-committed since you're not a committer.  In the future be sure to set commit-queue=? if you want things auto-committed (or make other arrangements to have a committer land your patch for you.)  See http://webkit.org/coding/contributing.html.
Comment 5 WebKit Commit Bot 2009-09-23 17:55:06 PDT
Comment on attachment 39973 [details]
build patch #2

Clearing flags on attachment: 39973

Committed r48692: <http://trac.webkit.org/changeset/48692>
Comment 6 WebKit Commit Bot 2009-09-23 17:55:09 PDT
All reviewed patches have been landed.  Closing bug.