RESOLVED FIXED 29660
Move "Generate 64-bit Export File" build phase script into DerivedSources.make 
https://bugs.webkit.org/show_bug.cgi?id=29660
Summary Move "Generate 64-bit Export File" build phase script into DerivedSources.make
David Kilzer (:ddkilzer)
Reported 2009-09-22 16:33:54 PDT
Created attachment 39960 [details] Patch v1 Reviewed by NOBODY (OOPS!). The "Generate 64-bit Export File" build phase script built the WebKit.LP64.exp export file used to link 64-bit WebKit. Instead of having a separate build phase script, move its generation into DerivedSources.make where WebCore.exp is generated. Note that because of VPATH usage in DerivedSources.make WebCore.LP64.exp had to be renamed to WebCore.LP64.base.exp. * DerivedSources.make: Added a rule to make WebCore.LP64.exp. * WebCore.LP64.base.exp: Renamed from WebCore/WebCore.LP64.exp. * WebCore.xcodeproj/project.pbxproj: Removed the "Generate 64-bit Export File" build phase script. --- 5 files changed, 44 insertions(+), 37 deletions(-)
Attachments
Patch v1 (6.91 KB, patch)
2009-09-22 16:33 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h (2.54 KB, patch)
2009-09-22 18:03 PDT, David Kilzer (:ddkilzer) 		mrowe: review+
DetailsFormatted DiffDiff
Move "Generate 64-bit Export File" build phase script into DerivedSources.make (7.31 KB, patch)
2009-09-22 18:03 PDT, David Kilzer (:ddkilzer) 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2009-09-22 16:37:46 PDT
(In reply to comment #0) > The "Generate 64-bit Export File" build phase script built the > WebKit.LP64.exp export file used to link 64-bit WebKit. Instead Already changed "WebKit.LP64.exp" to "WebCore.LP64.exp" and "WebKit" to "WebCore" above.
David Kilzer (:ddkilzer)
Comment 2 2009-09-22 17:18:05 PDT
Comment on attachment 39960 [details] Patch v1 Clearing the review? flag based on comments from a private discussion with Mark.
David Kilzer (:ddkilzer)
Comment 3 2009-09-22 18:03:47 PDT
Created attachment 39969 [details] Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h
David Kilzer (:ddkilzer)
Comment 4 2009-09-22 18:03:50 PDT
Created attachment 39970 [details] Move "Generate 64-bit Export File" build phase script into DerivedSources.make
Mark Rowe (bdash)
Comment 5 2009-09-23 11:16:42 PDT
Comment on attachment 39969 [details] Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h r=me
Mark Rowe (bdash)
Comment 6 2009-09-23 11:21:43 PDT
Comment on attachment 39970 [details] Move "Generate 64-bit Export File" build phase script into DerivedSources.make r=me
David Kilzer (:ddkilzer)
Comment 7 2009-09-23 15:04:06 PDT
Committed r48685: <http://trac.webkit.org/changeset/48685> Committed r48686: <http://trac.webkit.org/changeset/48686>
David Kilzer (:ddkilzer)
Comment 8 2009-09-23 19:19:23 PDT
Committed r48686: <http://trac.webkit.org/changeset/48686>
Note You need to log in before you can comment on or make changes to this bug.