Bug 29652 – RenderThemeChromiumWin should use true system colors for CSS system colors

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Peter Kasting]

Right now we fall back to the default hardcoded values in RenderTheme.  This means that e.g. the search buttons on google.com (which have recently changed to using CSS system colors) are illegible in white-on-black system themes.

RenderThemeWin.cpp has some appropriate-looking code, so the fix is easy: copy it.

[Peter Kasting]

Created attachment 39944 [details]
patch v1

[David Levin]

Comment on attachment 39944 [details]
patch v1

Two minor nits to fix up on landing.

> Index: WebCore/rendering/RenderThemeChromiumWin.cpp
> ===================================================================
> +// Map a CSSValue* system color to an index understood by GetSysColor

Please add a period to the end of the sentence.

> +static int cssValueIdToSysColorIndex(int cssValueId)
> +{
> +    switch (cssValueId) {
> +        case CSSValueActiveborder: return COLOR_ACTIVEBORDER;

A case label should line up with its switch statement (see http://webkit.org/coding/coding-style.html)

[Eric Seidel (no email)]

Comment on attachment 39944 [details]
patch v1

Looks sane to me too.  Dave just beat me!

[Peter Kasting]

Both comments addressed and patch landed in r48652.