Opera recently removed rendering support for the <basefont> element to be in line with Gecko/WebKit, but the interface is still there because it is still in Gecko/WebKit. Would it be possible to clean this up or are we forever stuck with it? (I realize we're forever stuck with the quirk in the parser.) Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=518110
Gecko did this.
Blink: http://code.google.com/p/chromium/issues/detail?id=231042
Would removing this break anything downstream of the Apple ports?
Nuke it.
Created attachment 201847 [details] Provisional patch
Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API.
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/480105
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/470587
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/467943
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/473579
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/477544
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/470615
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/474623 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html http/tests/security/cross-frame-access-get.html
Created attachment 201878 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/471702 New failing tests: http/tests/security/cross-frame-access-put.html
Created attachment 201879 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/473649
Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/481204 New failing tests: http/tests/security/cross-frame-access-put.html
Created attachment 201886 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 201978 [details] Provisional patch
Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/491083
Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/488110
Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/480562
Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/486168
Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/487157
Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/480573
Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/484584
Created attachment 202619 [details] Patch
(In reply to comment #28) > Created an attachment (id=202619) [details] > Patch That's the patch, all the build failures are due to stale bindings that are not updated after the interface is removed and are still including the JSHTMLBaseFont.h header.
Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/574024
Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/582026
Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/542267
Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/579014
Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/538254
Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/582033
Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/625033
It seems like this patch is removing support for basefont in the parser. Both Gecko and Blink only removed the interface so <basefont> maps to HTMLElement and not HTMLUnknownElement.
Comment on attachment 202619 [details] Patch r- since this patch doesn't build.
Created attachment 212813 [details] Provisional patch Here's the patch that makes the basefont tag fall back to HTMLUnknownElement and removes the HTMLBaseFontElement interface entirely from the source tree. Unfortunately none of the build systems can complete an incremental build with this patch applied since the generated JSC bindings source code that indirectly includes the removed HTMLBaseFontElement.h header doesn't get regenerated. So this is pretty much blocked until a coordinated effort can be made to enforce clean builds after this lands, or until a mechanism is introduced that would somehow make it possible to have build-webkit enforce clean builds on specific commits.
Seems this got fixed somehow meanwhile. At least html/semantics/interfaces.html no longer suggests <basefont> triggers the old interface in Safari TP.
(In reply to Anne van Kesteren from comment #40) > Seems this got fixed somehow meanwhile. At least > > html/semantics/interfaces.html > > no longer suggests <basefont> triggers the old interface in Safari TP. Likely fixed via Bug 161004.