Bug 29623 - Media test files in Ogg and Theora formats
Summary: Media test files in Ogg and Theora formats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-21 17:39 PDT by Hin-Chung Lam
Modified: 2009-09-23 10:55 PDT (History)
2 users (show)

See Also:


Attachments
Test files for ogg and theora, transcoded from originals (431.86 KB, patch)
2009-09-21 17:43 PDT, Hin-Chung Lam
no flags Details | Formatted Diff | Diff
Test files for ogg and theora, transcoded from originals (431.86 KB, patch)
2009-09-21 17:44 PDT, Hin-Chung Lam
no flags Details | Formatted Diff | Diff
Test files for ogg and theora, transcoded from originals (431.86 KB, patch)
2009-09-21 17:44 PDT, Hin-Chung Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2009-09-21 17:39:42 PDT
Provide Ogg and Theora formatted test files.
Comment 1 Hin-Chung Lam 2009-09-21 17:43:35 PDT
Created attachment 39896 [details]
Test files for ogg and theora, transcoded from originals
Comment 2 Hin-Chung Lam 2009-09-21 17:44:23 PDT
Created attachment 39897 [details]
Test files for ogg and theora, transcoded from originals
Comment 3 Hin-Chung Lam 2009-09-21 17:44:49 PDT
Created attachment 39898 [details]
Test files for ogg and theora, transcoded from originals
Comment 4 Eric Seidel (no email) 2009-09-22 14:37:46 PDT
Seems fine to me, although Eric would be the best person to rubber stamp this.
Comment 5 Eric Carlson 2009-09-22 14:47:41 PDT
Comment on attachment 39898 [details]
Test files for ogg and theora, transcoded from originals

r(ubberstamp) = me
Comment 6 WebKit Commit Bot 2009-09-22 15:25:36 PDT
Comment on attachment 39898 [details]
Test files for ogg and theora, transcoded from originals

Rejecting patch 39898 from commit-queue.

Patch https://bugs.webkit.org/attachment.cgi?id=39898 from bug 29623 failed to download and apply.
Comment 7 Eric Seidel (no email) 2009-09-22 15:28:17 PDT
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patch: **** Only garbage was found in the patch input.
patching file LayoutTests/media/content/garbage.ogv
error: pathspec 'LayoutTests/media/content/counting.ogv' did not match any file(s) known to git.
Did you forget to 'git add'?
error: pathspec 'LayoutTests/media/content/silence.oga' did not match any file(s) known to git.
Did you forget to 'git add'?
error: pathspec 'LayoutTests/media/content/test.oga' did not match any file(s) known to git.
Did you forget to 'git add'?
error: pathspec 'LayoutTests/media/content/test.ogv' did not match any file(s) known to git.
Did you forget to 'git add'?

I think this is known trouble with svn-apply and git patches.  I'm not sure though.
Comment 8 Eric Seidel (no email) 2009-09-22 15:29:15 PDT
This looks like the same failures as bug 29100, but I just fixed that, so I'm not sure.  Maybe I didn't fix it right.
Comment 9 Hin-Chung Lam 2009-09-22 15:31:29 PDT
I generate the patch using svn-create-patch but not git, would this be the reason?
Comment 10 Eric Carlson 2009-09-22 21:57:53 PDT
The problem was with the entry for empty.oga:

Index: LayoutTests/media/content/empty.oga
===================================================================

patch apparently can't handle a completely empty file. I removed that line from the patch, applied it locally, created the empty.oga manually, and added it to svn and all was fine.

http://trac.webkit.org/changeset/48667
Comment 11 Eric Seidel (no email) 2009-09-22 23:01:15 PDT
(In reply to comment #10)
> The problem was with the entry for empty.oga:
> 
> Index: LayoutTests/media/content/empty.oga
> ===================================================================
> 
> patch apparently can't handle a completely empty file. I removed that line from
> the patch, applied it locally, created the empty.oga manually, and added it to
> svn and all was fine.
> 
> http://trac.webkit.org/changeset/48667

Seems like we'll need to file a bug about that.  svn-apply should be able to handle such.
Comment 12 Eric Carlson 2009-09-23 08:12:50 PDT
Filed https://bugs.webkit.org/show_bug.cgi?id=29684
Comment 13 Hin-Chung Lam 2009-09-23 10:55:51 PDT
Thanks for the review and landing this for me!