RESOLVED FIXED 29619
Incorrect Win baseline for Layout test fast/canvas/toDataURL-supportedTypes 
https://bugs.webkit.org/show_bug.cgi?id=29619
Summary Incorrect Win baseline for Layout test fast/canvas/toDataURL-supportedTypes
Victor Wang
Reported 2009-09-21 15:38:47 PDT
Hi Sam, While I investigate this layout test failure in chromium, it looks to me that the windows baseline (LayoutTests/platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt) is out of date and this test should not be skipped. The test for Windows used to fail but your patch (http://trac.webkit.org/changeset/35290) rewrote the test to not output the encoded image data, so it should pass now. I think we could remove this window specific baseline and fallback to the baseline in the test folder. You are the person who originally added the baseline, so I would like to confirm with you before changing it. I tested it locally and it works fine. Removing the Win baseline also fixes the issue in Chromium. Thanks, Victor
Attachments
Proposed patch (9.31 KB, patch)
2009-09-23 09:07 PDT, Victor Wang 		abarth: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2009-09-23 09:07:00 PDT
Created attachment 39998 [details] Proposed patch I think the win baseline for this test could be removed.
Adam Barth
Comment 2 2009-09-23 09:30:22 PDT
Comment on attachment 39998 [details] Proposed patch Nice find! We should wait a bit to give Sam a chance to speak up if there's something subtle here.
Sam Weinig
Comment 3 2009-09-24 10:56:10 PDT
Everything looks good here. r=me as well.
Eric Seidel (no email)
Comment 4 2009-09-24 13:23:28 PDT
Comment on attachment 39998 [details] Proposed patch Victor is not a committer, so adding cq+.
WebKit Commit Bot
Comment 5 2009-09-24 13:45:45 PDT
Comment on attachment 39998 [details] Proposed patch Rejecting patch 39998 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39998 from bug 29619 failed to download and apply.
Eric Seidel (no email)
Comment 6 2009-09-28 13:32:07 PDT
patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/win/Skipped patching file LayoutTests/platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt rm 'LayoutTests/platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt' Could not open 'LayoutTests/platform/win/fast/canvas' to list files: 0 at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 358, <> line 99. That's a new one. It might be an error in svn-apply, not sure.
Victor Wang
Comment 7 2009-10-13 15:22:23 PDT
Reviewed patches have been landed. Closing bug
Note You need to log in before you can comment on or make changes to this bug.