WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
296166
Use std::unique_ptr instead of MallocPtr in ConcurrentBuffer and SegmentedVector
https://bugs.webkit.org/show_bug.cgi?id=296166
Summary
Use std::unique_ptr instead of MallocPtr in ConcurrentBuffer and SegmentedVector
Vassili Bykov
Reported
2025-07-17 22:27:19 PDT
We are about to harden MallocPtr by requiring the parameter type to be trivially destructible. That will prevent accidentally introduced memory leaks, when a type is used with MallocPtr under the assumption it does not need a destructor call, but is later changed to require non-trivial destruction (
https://bugs.webkit.org/show_bug.cgi?id=294022
). Two recently merged PRs introduce uses of MallocPtr incompatible with this upcoming change:
https://github.com/WebKit/WebKit/pull/47965
https://github.com/WebKit/WebKit/pull/48000
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-07-17 22:27:34 PDT
<
rdar://problem/156121020
>
Vassili Bykov
Comment 2
2025-07-17 23:26:08 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/48227
EWS
Comment 3
2025-07-18 10:40:39 PDT
Committed
297601@main
(002b94dcc58e): <
https://commits.webkit.org/297601@main
> Reviewed commits have been landed. Closing PR #48227 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug