Bug 29582 - REGRESSION: [Chromium] drop down selects fail to close when a value is selected
Summary: REGRESSION: [Chromium] drop down selects fail to close when a value is selected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-21 08:47 PDT by Darin Fisher (:fishd, Google)
Modified: 2009-09-21 09:07 PDT (History)
1 user (show)

See Also:


Attachments
v1 patch (3.12 KB, patch)
2009-09-21 08:58 PDT, Darin Fisher (:fishd, Google)
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-09-21 08:47:25 PDT
REGRESSION: [Chromium] drop down selects fail to close when a value
is selected

This is a regression from http://trac.webkit.org/changeset/48370

The change to RenderMenuList.cpp causes PopupMenu::hide() to no
longer be called.  It looks like the Chromium implementation was a
bit different than the other ports in its dependency on this.
Comment 1 Darin Fisher (:fishd, Google) 2009-09-21 08:58:49 PDT
Created attachment 39854 [details]
v1 patch
Comment 2 Dimitri Glazkov (Google) 2009-09-21 09:01:04 PDT
Comment on attachment 39854 [details]
v1 patch

r=me.

>      // Hides the popup.  Do not call this directly: use client->hidePopup().
This ain't true no more.
Comment 3 Darin Fisher (:fishd, Google) 2009-09-21 09:07:14 PDT
Landed as http://trac.webkit.org/changeset/48585