WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
295712
[ews] Rename pr_id to pr_number
https://bugs.webkit.org/show_bug.cgi?id=295712
Summary
[ews] Rename pr_id to pr_number
Aakash Jain
Reported
2025-07-10 08:28:02 PDT
In ews-app (and ews-build) we used two different variable names `pr_id` and `pr_number` in various places to refer to one thing, GitHub PR number. We should consolidate to use a single one. `pr_number` is more appropriate variable name for this, since it's not a unique id, and GitHub also refers to it as PR number in its documentation/API.
Attachments
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2025-07-10 09:57:27 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/47828
Radar WebKit Bug Importer
Comment 2
2025-07-10 10:16:22 PDT
<
rdar://problem/155537356
>
EWS
Comment 3
2025-07-15 08:01:30 PDT
Committed
297396@main
(967fe34df0a8): <
https://commits.webkit.org/297396@main
> Reviewed commits have been landed. Closing PR #47828 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug