Bug 29552 – [Qt] API: Make it possible to customize the DND behaviour of QWebView/QWebPage

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit Qt

[Tor Arne Vestbø]

This bug report originated from Nokia internal issue QT-1259

--- Description ---

QWebView by default accepts drops of URLs onto the page background. In a browser environment that is a nice feature, but when embedding webkit in an application this may not be wanted at all.

We need an API that allows customizing this behaviour.

--- Comments ---

Note: shausman: 02/13/09 04:00:36 AM:
Once this is implemented we can remove the setAcceptDrops(false) workarounds in Qt Creator and the Qt Assistant

[Aparna Nandyal]

Created attachment 85938 [details]
Patch for review

Patch to block drop action if user does not require drop action.

[Benjamin Poulain]

Comment on attachment 85938 [details]
Patch for review

I think this is not that easy. Your patch will prevent all drop to the page. The initial problem was about changing the current document as a result of a drag and drop.

You should still be able to
-handle HTML 5 drag and drop
-drop thing in the page, like dropping the url to an input field or an element with contentEditable

[Antonio Gomes]

Comment on attachment 85938 [details]
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=85938&action=review

It will probably not build on mac.

> Source/WebCore/ChangeLog:8
> +        Added new flag with which the user can enable/disable Drop feature.

drop = drag and drop?

> Source/WebCore/page/Settings.cpp:540
> +void Settings::setDropActionEnabled(bool dropActionEnabled)
> +{
> +    m_dropActionEnabled = dropActionEnabled;
> +}
> +

you should initialize m_dropActionEnabled in the ctor initialization list.

[Benjamin Poulain]

Thinking about it, I am not sure we really need new API at all. For the mentioned use case, I think overriding QWebPage::acceptNavigationRequest() to reject any external scheme could be as good.

Simon, what do you think? Are you aware of other use cases?

[Aparna Nandyal]

> -drop thing in the page, like dropping the url to an input field or an element with contentEditable

Thought of this use case but was not sure if drop has to be stopped completely or only url drop has to be stopped or if both settings should be made available?  Will re-implement based on decision taken.

[Aparna Nandyal]

(In reply to comment #3)
> (From update of attachment 85938 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85938&action=review
> 
> It will probably not build on mac.
> 
> > Source/WebCore/ChangeLog:8
> > +        Added new flag with which the user can enable/disable Drop feature.
> 
> drop = drag and drop?
> 
This stops only drop. Drag will still work. User will be able to drag content from this page out.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.